Correct tooltip wording for watch-only wallets #792

1. 
   hernanmarino commented at 4:31 am on February 9, 2024: contributor

   This is a continuation of #37 This is a simple change, but imho necessary because it leads to confusion. The objective of this change is to provide a better description for the tooltip for the “Available Balance” balance because the current version on master mentions the word “You current spendable balance” which is a bit misleading, because that balance is not always spendable , or not always yours on watch only wallets.
2. gui: Show spendable balance for keyless watch-only

   Make labelSpendable visible for watch only wallets
   with their private keys disabled.
   Also set the labelBalance accordingly for the same
   condition.
   
   Co-authored-by: saibato <saibato.naga@pm.me>

   2e24c0cc10
3. 
   DrahtBot commented at 4:31 am on February 9, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #bitcoin/bitcoin/28710 (Remove the legacy wallet and BDB dependency by achow101)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. 
   hernanmarino commented at 4:38 am on February 9, 2024: contributor

   As a first commit, I only took @ saibato’s latest commit and corrected a couple of bugs (mentioned by @pablomartin4btc in the original PR.) Marked as Draft, in the following days I’ll try to address all comments and sugestions in that PR, and mark it ready for review.
5. hebasto renamed this:
   gui: Correct tooltip wording for watch-only wallets
   Correct tooltip wording for watch-only wallets
   on Feb 9, 2024
6. in src/qt/overviewpage.cpp:203 in 2e24c0cc10

   196@@ -197,7 +197,10 @@ void OverviewPage::setBalance(const interfaces::WalletBalances& balances)
   197     BitcoinUnit unit = walletModel->getOptionsModel()->getDisplayUnit();
   198     if (walletModel->wallet().isLegacy()) {
   199         if (walletModel->wallet().privateKeysDisabled()) {
   200+            ui->labelSpendable->setText(tr("Watch-only:"));
   201+            ui->labelSpendable->setVisible(true);
   202             ui->labelBalance->setText(BitcoinUnits::formatWithPrivacy(unit, balances.watch_only_balance, BitcoinUnits::SeparatorStyle::ALWAYS, m_privacy));
   203+            ui->labelBalance->setToolTip(tr("Your current balance in watch-only addresses"));
   

   ---

   ---

   

   luke-jr commented at 10:32 pm on February 20, 2024:

   Despite the confusing interfaces, watch-only wallets are not based on addresses (or they would never see spends). Prefer to use less confusing language here.

   ---

   

   pablomartin4btc commented at 10:26 pm on March 26, 2024:

   Perhaps “Your current watch-only balance” or “Your current watch-only wallet balance”?
7. luke-jr changes_requested
8. 
   hebasto commented at 12:55 pm on May 12, 2024: member

   @hernanmarino

   Are you still working on this?

9. 
   hernanmarino commented at 9:51 pm on May 21, 2024: contributor

   @hernanmarino

   Are you still working on this?

   I am active, and I’ll resume working on this PR and upload a proposal soon.

10. 
    hebasto commented at 3:42 pm on July 15, 2024: member

    Closing for now. Please feel free to reopen it when a non-draft version is ready.
11. hebasto closed this on Jul 15, 2024

    ---

Contributors
hernanmarino DrahtBot luke-jr pablomartin4btc hebasto