Use random free port for test_bitcoin-qt #10

issue achow101 openend this issue on June 22, 2020
  1. achow101 commented at 8:19 pm on June 22, 2020: member

    Currently the test_bitcoin-qt unit test uses the standard regtest port. It will fail to start if something else is using the regtest port, like a regtest instance of bitcoind or bitcoin-qt. Or another running test_bitcoin-qt (this happens if you are updating multiple branches at the same time). Instead of using the standard regtest port, this unit test should be using a random free port like we do in the functional tests.

    Want to work on this issue?

    For guidance on contributing, please read CONTRIBUTING.md before opening your pull request.

  2. achow101 added the label good first issue on Jun 22, 2020
  3. dongcarl commented at 8:21 pm on June 22, 2020: contributor
    I think you’re able to let the system assign one if you use port 0
  4. promag commented at 8:43 pm on June 22, 2020: contributor
    Concept ACK, also @dongcarl 👍
  5. laanwj referenced this in commit 924a4ff7eb on Oct 29, 2020
  6. jonasschnelli referenced this in commit c33662a0ea on Dec 2, 2020
  7. hebasto added the label Tests on Mar 6, 2021
  8. MarcoFalke closed this on Mar 8, 2021

  9. MarcoFalke referenced this in commit 590e49ccf2 on Apr 4, 2021
  10. MarcoFalke referenced this in commit bce09da122 on Apr 28, 2021
  11. fanquake referenced this in commit fa00bb2c5c on Apr 29, 2021
  12. MarcoFalke referenced this in commit eb9a1fe037 on May 7, 2021
  13. laanwj referenced this in commit ee9befe8b4 on May 12, 2021
  14. MarcoFalke referenced this in commit c857148636 on May 15, 2021
  15. fanquake referenced this in commit f9b522e50d on Feb 23, 2022
  16. bitcoin-core locked this on Aug 16, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 12:20 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me