Drop workaround for fixed QTBUG-42503 #101

issue hebasto opened this issue on October 8, 2020

hebasto commented at 10:38 AM on October 8, 2020: member

In the code https://github.com/bitcoin-core/gui/blob/9dd4de2832e298398436b957375d62de67f0a928/src/qt/overviewpage.cpp#L128

we should drop the workaround for QTBUG-42503 which is already fixed since Qt 5.5.0.

Disclaimer: I'm not able to test a patch as testing requires retina display.
prusnak referenced this in commit a2a3f4cd8d on Jan 19, 2021
prusnak commented at 3:39 PM on January 19, 2021: contributor

PR in https://github.com/bitcoin-core/gui/pull/189
jonasschnelli closed this on Jan 26, 2021
jonasschnelli closed this on Jan 26, 2021
jonasschnelli referenced this in commit 5f65f13597 on Jan 26, 2021
remyers referenced this in commit adac0c6f04 on Jan 26, 2021
sidhujag referenced this in commit d72a209295 on Jan 26, 2021
jonasschnelli reopened this on Jan 26, 2021
jonasschnelli commented at 4:23 PM on January 26, 2021: contributor

I keep this PR open since we still use a QPushButton for those icons (rather than a QLabel).
prusnak commented at 4:34 PM on January 26, 2021: contributor
How should a QLabel with an icon work?

Via the html img hack?
```
QLabel("<html><img src=':/resource.png'></html>")
```
Or should we use 2 QLabels for each QPushButton (one with an icon, the other with a text)?
jonasschnelli commented at 6:54 PM on January 26, 2021: contributor

AFAIK you can just use QLabel::setPixmap() (along with setText()).
fanquake closed this on Jan 27, 2021
fanquake reopened this on Jan 27, 2021
laanwj commented at 5:09 PM on January 27, 2021: member

I am fairly sure you need two labels in that case, one with the pixmap one with the text. Otherwise, the label doesn't know how you want to position the icon and text relative to each other.

When it's possible to avoid using HTML that's generally preferable.
prusnak commented at 5:39 PM on January 27, 2021: contributor
I also think it's not possible to set both icon and text for a label.

Here's the trick how to solve it via VBoxLayout containing two labels https://forum.qt.io/topic/64020/settext-and-setpixmap-using
```
QWidget * container = new QWidget(this);
QVBoxLayout * layout = new QVBoxLayout(container);
QLabel * textLabel = new QLabel(container);
QLabel * imageLabel = new QLabel(container);

layout->addWidget(imageLabel);
layout->addWidget(textLabel);

imageLabel->setPixmap(...);
textLabel->setText(...);
```
Honestly, I am not so sure that's better than using a QPushButton
jonasschnelli commented at 8:33 PM on January 27, 2021: contributor

Let's keep the QPushButton then. Closing.
jonasschnelli closed this on Jan 27, 2021
bitcoin-core locked this on Aug 16, 2022

Contributors

Linked (view graph)

#189 qt: drop workaround for QTBUG-42503 which was fixed in Qt 5.5.0