Wrong dialog icon for “Wallet to be encrypted” #106

1. 
   jonasschnelli commented at 10:59 am on October 23, 2020: contributor

   The used icon in the “Wallet to be encrypted” is rather one used for “errors”:

   Ideally there is a non-red icon so people aren’t thinking something went wrong.

2. jonasschnelli added the label Bug on Oct 23, 2020
3. 
   jonasschnelli commented at 11:03 am on October 23, 2020: contributor

   On the other hand, we might want to use a warning icon to make people actual read the content… so unsure if we should fix this.
4. 
   MarcoFalke commented at 11:41 am on October 23, 2020: contributor

   I’d say this was intentional
5. 
   hebasto commented at 1:29 pm on October 23, 2020: member

   Hmm, I’ve got a yellow triangle:

   … and the QMessageBox::warning is used: https://github.com/bitcoin-core/gui/blob/49984b44cfcd3fd0cef16c8ce97197973afc3c04/src/qt/askpassphrasedialog.cpp#L130-L133

6. 
   jarolrod commented at 11:58 pm on October 30, 2020: member

   The red circle is the default icon for QMessageBox::critical, which would make this an interesting quirk. Also, it’s entirely possible that what is shown is a QMessageBox::warning with the wrong icon being passed because of your systems GTK cache files. Certain GTK themes can influence what icon actually comes up as Qt >5.7 implemented a feature that uses the system’s GTK cache files to load some icons. For example, I can get this white error symbol to come up:

   To stay consistent, we could just provide our own custom icon via: QMessageBoxName.setIcon(QMessageBox::setIconPixmap(arg))

7. 
   hebasto commented at 9:57 am on November 4, 2020: member

   @jarolrod

   … as Qt >5.7 implemented a feature that uses the system’s GTK cache files to load some icons.

   Could elaborate?

8. hebasto added the label Linux on Mar 5, 2021

Contributors
jonasschnelli MarcoFalke hebasto jarolrod

Labels
Bug Linux