Fix unreasonable default size of the main window without loaded wallets #116

pull hebasto wants to merge 1 commits into bitcoin-core:master from hebasto:201025-hint changing 2 files +13 −7
  1. hebasto commented at 7:46 PM on October 25, 2020: member

    This PR fixes a bug in master (d67883d01e507dd22d1281f4a4860e79d6a46a47) and in 0.20.1 that could be easily reproduced with

    $ src/qt/bitcoin-qt -regtest -resetguisettings -nowallet
    

    Screenshot from 2020-10-25 21-21-27 Screenshot from 2020-10-25 21-23-32

    With this PR:

    Screenshot from 2020-10-25 21-20-35 Screenshot from 2020-10-25 21-23-03


    Fix #104 Fix #113

    This PR is an alternative to #107 without hard-coding a size in pixels.

  2. qt: Add WalletFrame::sizeHint
    This change makes the layout of a WalletFrame widget correct even
    without loaded wallets.
    7b2e42ecc4
  3. hebasto commented at 7:48 PM on October 25, 2020: member
  4. luke-jr approved
  5. luke-jr commented at 9:00 PM on October 25, 2020: member

    tACK

  6. MarcoFalke added this to the milestone 0.21.0 on Oct 25, 2020
  7. promag commented at 1:00 AM on October 26, 2020: contributor

    Looks like it should take into account ModalOverlay size.

  8. hebasto commented at 9:05 AM on October 26, 2020: member

    @promag

    Looks like it should take into account ModalOverlay size.

    I've tried your suggestion and got: Screenshot from 2020-10-26 11-03-33

  9. jonasschnelli commented at 1:46 PM on October 27, 2020: contributor

    Tested ACK 7b2e42ecc4bddb5504665d6932dc5ffdbd3b593e - I can confirm this fixes #104 (Ubuntu 20.04 - HiDPI 200%).

  10. jonasschnelli merged this on Oct 27, 2020
  11. jonasschnelli closed this on Oct 27, 2020

  12. hebasto deleted the branch on Oct 27, 2020
  13. sidhujag referenced this in commit 63d4f53dde on Oct 27, 2020
  14. apoelstra referenced this in commit d930257d7c on Dec 3, 2020
  15. gwillen referenced this in commit 71593ae083 on Mar 23, 2021
  16. Fabcien referenced this in commit d6d1e97c43 on Dec 15, 2021
  17. bitcoin-core locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 23:20 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me