Remove BDB version from the Information tab #118

1. 
   hebasto commented at 2:17 PM on October 27, 2020: member

   Master (67d4643a1a763b893ee69f6bbbf59ef1f2cb0d51):

   This PR:

2. 
   jonasschnelli commented at 2:22 PM on October 27, 2020: contributor

   Yeah. Why not. Code Review ACK c61024cae2c72bf1c5a7ed088298e44e66b513a4

3. 
   promag commented at 2:01 PM on October 28, 2020: contributor

   Is this even useful in the GUI? Sounds like one of those things that a GUI user doesn't care about. Not even in the RPC console. I'd just remove it..

4. 
   achow101 commented at 4:12 PM on October 28, 2020: member

   Agree with @promag. It seems kind of useless to include this in the GUI.

5. gui: Remove BDB version from the Information tab e4fc45a011
6. hebasto force-pushed on Oct 28, 2020
7. hebasto renamed this:
   Hide BDB info when -disablewallet
   Remove BDB version from the Information tab
   on Oct 28, 2020
8. 
   hebasto commented at 4:35 PM on October 28, 2020: member

   @promag

   Is this even useful in the GUI? Sounds like one of those things that a GUI user doesn't care about. Not even in the RPC console. I'd just remove it.. @achow101 Agree with @promag. It seems kind of useless to include this in the GUI.

   BDB version string removed completely :) Please re-review.

9. 
   promag commented at 4:57 PM on October 28, 2020: contributor

   We leave it in the console?

10. 
    hebasto commented at 5:17 PM on October 28, 2020: member

    We leave it in the console?

    Not sure if I understand right what do you mean.

11. 
    promag commented at 5:24 PM on October 28, 2020: contributor

    Ah sorry @hebasto, forgot I was in another branch 🤦

12. 
    achow101 commented at 5:34 PM on October 28, 2020: member

    ACK e4fc45a0115eea8ad7ad7505dfcfd8cbe50b96da

13. 
    jonasschnelli commented at 7:08 PM on October 28, 2020: contributor

    Probably fine to remove it. I guess nobody is using this information. utACK e4fc45a0115eea8ad7ad7505dfcfd8cbe50b96da

14. 
    Sjors commented at 2:59 PM on October 30, 2020: member

    utACK e4fc45a

    This information can still be found in the debug log whenever you load a wallet.

15. 
    promag commented at 12:54 AM on November 2, 2020: contributor

    ACK e4fc45a0115eea8ad7ad7505dfcfd8cbe50b96da.

16. jarolrod approved
17. 
    jarolrod commented at 1:27 AM on November 11, 2020: member

    Tested ACK e4fc45a Built and tested on Arch Linux (Kernel 5.18.5) and macOS 10.15.7

18. jonasschnelli added this to the milestone 0.22.0 on Nov 11, 2020
19. MarcoFalke merged this on Nov 18, 2020
20. MarcoFalke closed this on Nov 18, 2020

    ---

21. hebasto deleted the branch on Nov 18, 2020
22. sidhujag referenced this in commit d8a7447198 on Nov 18, 2020
23. apoelstra referenced this in commit 3af358815d on Dec 3, 2020
24. gwillen referenced this in commit 03ca451e06 on Mar 23, 2021
25. bitcoin-core locked this on Feb 15, 2022

Contributors

hebastojonasschnellipromagachow101Sjorsjarolrod

Milestone
22.0