Replace QMetaObject::invokeMethod with atomic operations #127

pull hebasto wants to merge 1 commits into bitcoin-core:master from hebasto:201102-queued changing 2 files +6 −9

hebasto commented at 1:29 PM on November 2, 2020: member

No need to read/write a data member in one thread if it is atomic.
promag commented at 9:21 PM on November 2, 2020: contributor

An atomic bool would be enough?

Didn't want to mess with this in #120 because I think ballon filtering doesn't belong in transaction model. IMO the right place should be aware of what wallets are open.
qt: Replace QMetaObject::invokeMethod with atomic operations 6501bb3bdc
hebasto force-pushed on Nov 7, 2020
hebasto commented at 11:29 AM on November 7, 2020: member

@promag

An atomic bool would be enough?

You're right. Reworked.
hebasto renamed this:
~~Replace QMetaObject::invokeMethod with Mutex locking~~
Replace QMetaObject::invokeMethod with atomic operations
on Nov 7, 2020
promag commented at 8:53 AM on November 12, 2020: contributor

This doesn't work: setProcessingQueuedTransactions needs to be enqueued and proceed in between transaction notifications.
hebasto commented at 8:57 AM on November 12, 2020: member

This doesn't work: setProcessingQueuedTransactions needs to be enqueued and proceed in between transaction notifications.

Why?
promag commented at 9:00 AM on November 12, 2020: contributor

Transaction notifications are enqueued in TransactionNotification::invoke and by the time they are processed setProcessingQueuedTransactions(false) was already called.
hebasto commented at 9:22 AM on November 12, 2020: member

You mean that setProcessingQueuedTransactions must be placed into the same event queue as updateTransaction, i.e., coordinated?
hebasto closed this on Nov 12, 2020
promag commented at 9:27 AM on November 12, 2020: contributor

@hebasto yes, processingQueuedTransactions() value is worthless.
bitcoin-core locked this on Feb 15, 2022

Contributors

hebasto

promag