macOS 11 (Big Sur) visual bugs #136

1. 
   jonasschnelli commented at 8:40 pm on November 25, 2020: contributor

   Nighy build on Big Sur “dark mode”:

   Self compiled on Big Sur “night mode” with depends:

   Two major issues:

   • disabling the night mode color palette or adopt it correctly (probably a QT upstream issue)
   • get rid of the white glitch in the debug-window tab-bar-menu

   Qt upstream issue: https://bugreports.qt.io/browse/QTBUG-85546

2. jonasschnelli added the label Bug on Nov 25, 2020
3. jonasschnelli added the label macOS on Nov 25, 2020
4. 
   mjdietzx commented at 6:32 pm on November 26, 2020: contributor

   I also noticed what seems to be a bug on Big Sur. When I go to send a transaction from my encrypted wallet, I get a popup that says “Unlock wallet”. I enter the correct passphrase, but no matter what the “OK” button stays disabled and can’t be clicked. Usually I’d expect once you enter at least 1 char into the passphrase input, that button would become enabled/clickable
5. MarcoFalke referenced this in commit 854b36cfa2 on Nov 28, 2020
6. sidhujag referenced this in commit 0dddb26c8e on Nov 28, 2020
7. 
   goums commented at 2:22 pm on December 18, 2020: none

   I’ve tried to update the QPalette and the styleSheet of the widgets to fix the display glitches, but I didn’t manage to fix them as the bugs are directly in the QMacStyle widgets implementations.

   The QT team is working on it, but the underlying QT issues will probably take some time to be resolved and is tagged for QT6: https://bugreports.qt.io/browse/QTBUG-86513

   So one solution instead of waiting for QT6 release (and hoping for QMacStyle to be fixed) could be to force QApplication to use the default "Fusion" style on macos: https://doc.qt.io/qt-5/gallery.html

   This is a one line change, no added dependencies, and it supports Light / Dark modes out of the box.

   • Some screenshots using Fusion on DarkMode :

   • Some screen shot using Fusion on Light Mode :

8. 
   jonasschnelli commented at 3:25 pm on December 18, 2020: contributor

   @goums: can the fusion style be a runtime option? Or even a startup ENV parameter?
9. 
   goums commented at 8:31 pm on December 18, 2020: none

   Yes, according to the doc, it can be either set with a command line argument or an environment variable. https://doc.qt.io/qt-5/qapplication.html#QApplication

   I got an error Invalid parameter -style if I try to add it to the command line, but it works nice if I use the environment variable: QT_STYLE_OVERRIDE =fusion.

   It can be set on the Project > Build & Run > Run > Environment :

   NB: you need to fetch #154 to have the icon colorized on macos dark mode

10. 
    hebasto commented at 9:16 pm on January 7, 2021: member

    @jonasschnelli

    @goums: can the fusion style be a runtime option? Or even a startup ENV parameter?

    I think the former is disabled since https://github.com/bitcoin/bitcoin/pull/16578.

11. 
    hebasto commented at 10:04 pm on January 7, 2021: member

    A workaround is suggested in #177.
12. jonasschnelli referenced this in commit 02b01651c5 on Jan 28, 2021
13. 
    hebasto commented at 2:52 am on March 22, 2021: member

    @jonasschnelli

    It seems the most of visual bugs are gone after Qt bumping to 5.12.10 (https://github.com/bitcoin/bitcoin/pull/21376).

    A few things left like https://bugreports.qt.io/browse/QTBUG-86513.

    Efforts to support the dark mode are tracked in #154.

    Maybe, there are no reasons to keep this issue opened?

14. MarcoFalke referenced this in commit 3bcd278aa6 on Mar 29, 2021
15. 
    hebasto commented at 10:02 am on May 25, 2021: member

    It looks that after https://github.com/bitcoin/bitcoin/pull/22054 is merged this issue could be closed.
16. fanquake closed this on Jun 2, 2021

    ---

17. sidhujag referenced this in commit 6995f59cd9 on Jun 3, 2021
18. bitcoin-core locked this on Aug 16, 2022

Contributors
jonasschnelli mjdietzx goums hebasto

Labels
Bug macOS