As all deprecated warning in Qt 5.15.0 were eliminated in #46, Qt 5.15.1 introduced another one that is fixed in this PR.
Required for https://github.com/bitcoin/bitcoin/pull/20182.
Details in Qt docs:
refactor: Replace deprecated Qt::SystemLocale{Short,Long}Date #137
pull hebasto wants to merge 1 commits into bitcoin-core:master from hebasto:201127-locale changing 2 files +4 −2-
hebasto commented at 8:12 AM on November 27, 2020: member
-
refactor: Replace deprecated Qt::SystemLocale{Short,Long}Date 86b1ab64b1
-
promag commented at 1:19 PM on November 27, 2020: contributor
Was this identified with the latest 5.15.2?
-
hebasto commented at 1:29 PM on November 27, 2020: member
Was this identified with the latest 5.15.2?
5.15.2 was released on 2020-11-20, but the recent Qt the Homebrew provides still 5.15.1.
Warnings are fired on 5.15.1:
- https://cirrus-ci.com/task/5721548852035584?command=ci#L2816
- https://cirrus-ci.com/task/5721548852035584?command=ci#L2892
Did not test on 5.15.2.
UPDATE: Looking into code it seems I just missed those warnings in #46 :man_shrugging:
-
- jarolrod approved
-
jarolrod commented at 9:45 PM on November 27, 2020: member
Tested ACK 86b1ab6 on MacOS 10.15.7 and Arch Linux both with Qt 5.15.1
- Compiled both Master and PR with
make -j{n} |& tee compile.txt, then grepped this file withgrep -r "deprecated" - Can confirm that master raises these deprecation warnings and the PR fixes them
I also compiled with Qt 5.15.2 on Linux and can confirm that master still raises, and PR fixes. Furthermore, there are no new deprecated warnings.
- Compiled both Master and PR with
- jonasschnelli approved
-
jonasschnelli commented at 9:57 AM on December 1, 2020: contributor
Tested ACK 86b1ab64b1a5b56518787ef16ea54ddbbc97d83e
- jonasschnelli merged this on Dec 1, 2020
- jonasschnelli closed this on Dec 1, 2020
- sidhujag referenced this in commit fad2b2fac8 on Dec 1, 2020
- hebasto deleted the branch on Dec 1, 2020
- bitcoin-core locked this on Feb 15, 2022
