about:version:help clean up add Bitcoin branding

RandyMcMillan commented at 8:17 am on November 29, 2020: contributor

Before:

Screen Shot 2020-11-29 at 3 26 26 AM

After:

Updated default presentations:

in src/init.cpp:604 in c77690a16b outdated

599+std::string CopyrightInfo()
600+{
601+    return CopyrightHolders(strprintf(_("Copyright (C) %i-%i").translated, 2009, COPYRIGHT_YEAR) + " ");
602+}
603+
604+std::string AboutMessageInfo()

RandyMcMillan commented at 8:30 am on November 29, 2020:

The AboutMessageInfo() is simple and can be modified more easily in the future.

in src/qt/bitcoin.qrc:47 in c77690a16b outdated

43@@ -44,6 +44,7 @@
44         <file alias="hd_disabled">res/icons/hd_disabled.png</file>
45         <file alias="network_disabled">res/icons/network_disabled.png</file>
46         <file alias="proxy">res/icons/proxy.png</file>
47+        <file alias="bitcoin_core">res/icons/bitcoin_core.png</file>

RandyMcMillan commented at 8:33 am on November 29, 2020:

Added the png art that is used in the header of the about view.

RandyMcMillan commented at 8:11 pm on December 4, 2020:

Reuse of bitcoin.png is a better approach. Thanks for the feed back!

in src/qt/forms/helpmessagedialog.ui:9 in c77690a16b outdated

 5@@ -6,10 +6,13 @@
 6    <rect>
 7     <x>0</x>
 8     <y>0</y>
 9-    <width>780</width>
10-    <height>400</height>
11+    <width>602</width>

RandyMcMillan commented at 8:34 am on November 29, 2020:

The new configuration makes a better use of space - therefore the window doesn’t need to open as big.

RandyMcMillan commented at 8:13 pm on December 4, 2020:

The view’s dimensions are now dynamic and resize based on help/about context.

in src/qt/utilitydialog.cpp:41 in c77690a16b outdated

40@@ -41,21 +41,37 @@ HelpMessageDialog::HelpMessageDialog(QWidget *parent, bool about) :
41         setWindowTitle(tr("About %1").arg(PACKAGE_NAME));
42 
43         std::string licenseInfo = LicenseInfo();
44-        /// HTML-format the license message from the core
45+        std::string copyrightInfo = CopyrightInfo();

RandyMcMillan commented at 8:35 am on November 29, 2020:

The new implementation separates these strings.

REF: https://github.com/bitcoin-core/gui/pull/140/commits/e0ff8e263dc96199385e31e481e64ad3a242fcd9#r536346038

hebasto commented at 8:45 am on November 29, 2020: member

NACK on changes of -version command-line argument output layout.

jarolrod commented at 11:03 pm on November 29, 2020: member

These two sections should be aligned

RandyMcMillan commented at 4:48 am on December 1, 2020: contributor

@hebasto

I ensured that the output is uniform for -version (except for the word “version” in bitcoind -version)

I would prefer to take it out.. I believe v implies version and is redundant.

thanks for the feedback! :)

Screen Shot 2020-11-30 at 11 45 04 PM

jonasschnelli commented at 9:34 am on December 1, 2020: contributor

I like the new style. Though there is still a debate on whether the logo should be orange or black. #89

Concept ACK if we keep the color as is (we can always change it later to black if people want this).

RandyMcMillan marked this as a draft on Dec 2, 2020

Bosch-0 commented at 5:00 am on December 3, 2020: none

Concept ACK

The updated screenshots you posted above, the text should align with the logo such as below.

bitcoinheiro commented at 8:23 am on December 3, 2020: none

I would change that logo. This is Bitcoin, Core is secondary. Only forks want to reinforce the Core over Bitcoin.

Orange logo
Bitcoin bold
Core thin

Bosch-0 commented at 8:27 am on December 3, 2020: none

I would change that logo. This is Bitcoin, Core is secondary. Only forks want to reinforce the Core over Bitcoin.

I disagree with this view. The GUI this repo is for is a product developed by Core that uses the Bitcoin protocol. Other implementations may one day exist that work on Bitcoin that aren’t Core.

bitcoinheiro commented at 8:57 am on December 3, 2020: none

What do we want to communicate? Do we want to have more force on the name Bitcoin or Core?

We cannot be always thinking about other people concerns, the software is what it is and other implementations can exist - and they do exist - without the need to reinforce this concept on the logo and be “apologetic”.

I believe users of the Core implementation should feel they are running BITCOIN when running this “product” and not “Core”. When I see the black logo it makes me feel sad, it confuses me instead of reinforcing Bitcoin. Feels like you’re putting Bitcoin “in the closet” and we should be ashamed to be Bitcoin instead of proud of it.

Bosch-0 commented at 9:05 am on December 3, 2020: none

Do we want to have more force on the name Bitcoin or Core?

One or the other at this stage - currently both are used and its confusing.

I believe users of the Core implementation should feel they are running BITCOIN

You can still achieve this whilst using the black logo - do people think they are running something else when using products like electrum or bluewallet? I’d say no. This is the designers job to communicate this effectively and use the black and orange logos in their appropriate locations.

Do most people see Bitcoin Core = Bitcoin?

bitcoinheiro commented at 9:13 am on December 3, 2020: none

Do most people see Bitcoin Core = Bitcoin? I believe people do and you’re exactly trying to use the design to communicate otherwise. I don’t think people have to be communicated otherwise.

Why Bitcoin so thin and Core so bold? Isn’t that trying to communicate Core over Bitcoin? This project is not Electrum or BlueWallet, it’s Bitcoin.

Bosch-0 commented at 9:18 am on December 3, 2020: none

I’ve already explained my rationale many times above.

I’m still of the thought that:

Bitcoin Core is a group of developers who work on Bitcoin.

Bitcoin is a network that everyone is apart of.

Electrum and BlueWallet are part of the Bitcoin ecosystem as is the GUI developed by the Core developers.

jonatack commented at 9:27 am on December 3, 2020: contributor

I agree with not emphasizing “Core”. Let’s not institutionalize that emphasis further. Please keep them equal or put more weight on “Bitcoin”.

One of my pet peeves is people writing “Core” instead of “Bitcoin Core” (“Core devs”, “running Core”, and so on).

See the Bitcoin Optech style guide:

0Forbidden abbreviations:
1
2Core (use Bitcoin Core)

100% agree with our Bitcoin Optech colleagues about this.

jonasschnelli commented at 9:59 am on December 3, 2020: contributor

Don’t get me wrong. I originally designed the black logo and I like it. Though @gmaxwell made a valid comment here.

Changing the color might have greater impact than originally anticipated.

jonatack commented at 10:15 am on December 3, 2020: contributor

Concept ACK, sorry about not reviewing the PR itself, in general this looks very nice @RandyMcMillan and is a good improvement.

promag commented at 11:18 am on December 3, 2020: contributor

I’d be happy to ACK everything but the logo change, maybe you want to split the PR?

RandyMcMillan commented at 10:40 pm on December 3, 2020: contributor

Thank you for the feed back!

RandyMcMillan commented at 10:47 pm on December 3, 2020: contributor

I agree with the statement

The Bitcoin Core Developers

is a group and this is why I’ve maintained that “Developers” should be capitalized in the branding.

Further more…

From a copyright perspective - THE BITCOIN CORE DEVELOPERS should be in all caps - but this isn’t mandated in any legalese that I have read…

But that is outside the scope of this PR. :)

RandyMcMillan commented at 0:27 am on December 4, 2020: contributor

I didn’t see the link - agree.

#89 (comment)

The logo should remain orange. This change would inadvertantly play into efforts to create a false equivalence between Bitcoin and various fraudulent clones.

We now know through leaked emails that even the renaming of Bitcoin Core to that name was dishonestly driven by malicious intent– the parties that pushed for the name change did so because they were intending to attempt to take over Bitcoin from the community and move it under their control, and they wanted to “other” the community project and disassociate it with Bitcoin. Going along with it was an error. It’s water under the bridge now but there is no reason to continue being victimized by past wrongs and compounding a past error.

jarolrod commented at 1:43 am on December 4, 2020: member

Tested ACK 5210082 NACK on the current logo text, it looks really bad IMO. logo

Also the about page and command-line options page don’t need to be the same size. There’s a lot of unused space in the about page because they’re set to be the same size.

RandyMcMillan commented at 2:18 am on December 4, 2020: contributor

@jarolrod - please add some context to the pic you posted. OS - Screen resolution - dark theme? etc… Thanks.

jarolrod commented at 2:25 am on December 4, 2020: member

@jarolrod - please add some context to the pic you posted. OS - Screen resolution - dark theme? etc… Thanks.

OS: Arch Linux, DE: KDE Plasma 5.19.5, Res:3440x1440 The picture is pixelated because its cropped. Below is the full photo. I was trying to point out that everything looks off. The Bitcoin logo is in a weird position in relation to the logo text and the seperator bar. The logo text appears to have weird spacing. I’m not a designer, but this looks off to me. comand-line-options-page

RandyMcMillan commented at 3:52 am on December 4, 2020: contributor

Removed excessive space in the aboutMessage body. These are the default dimensions when they first appear.

Screen Shot 2020-12-03 at 11 00 53 PM

RandyMcMillan marked this as ready for review on Dec 4, 2020

RandyMcMillan renamed this:
~~about-view: clean up - Bitcoin Core logo~~
about-view: clean up - Bitcoin branding
on Dec 4, 2020

in src/qt/bitcoingui.cpp:849 in e0ff8e263d outdated

845@@ -846,6 +846,7 @@ void BitcoinGUI::showDebugWindowActivateConsole()
846 void BitcoinGUI::showHelpMessageClicked()
847 {
848     helpMessageDialog->show();
849+    helpMessageDialog->raise();//bring to top if obscured

RandyMcMillan commented at 7:30 pm on December 4, 2020:

If the helpMessageDialog has already been presented - this change brings it to the front if the user re-clicks on the help menu item - otherwise it may remain obscured by any other windows.

in src/qt/utilitydialog.cpp:36 in e0ff8e263d outdated

32@@ -33,29 +33,46 @@ HelpMessageDialog::HelpMessageDialog(QWidget *parent, bool about) :
33     ui(new Ui::HelpMessageDialog)
34 {
35     ui->setupUi(this);
36-
37+    this->resize(500,0);//force view height to stretch

RandyMcMillan commented at 7:35 pm on December 4, 2020:

The Ui::HelpMessageDialog is shared with the about view. These change forces the view to stretch to an appropriate height - this eliminates excessive height dimensions - the user resizes based upon personal preference.

in src/qt/utilitydialog.cpp:72 in e0ff8e263d outdated

77+        ui->versionInfo->setText(versionInfoHTML);
78+
79+
80+    if (about)
81+    {
82+        setWindowTitle(tr("About %1").arg(PACKAGE_NAME));

RandyMcMillan commented at 7:42 pm on December 4, 2020:

Over riding PACKAGE_NAME is outside the scope of this PR.

This PR is implementing changes based on broader community discussions and sentiment.

REF: #89 (comment)

REF: #140 (comment)

in src/bitcoind.cpp:61 in e0ff8e263d outdated

54@@ -55,10 +55,10 @@ static bool AppInit(int argc, char* argv[])
55 
56     // Process help and version before taking care about datadir
57     if (HelpRequested(args) || args.IsArgSet("-version")) {
58-        std::string strUsage = PACKAGE_NAME " version " + FormatFullVersion() + "\n";
59+        std::string strUsage = PACKAGE_NAME " version " + FormatFullVersion() + "\n";//from init.cpp
60 
61         if (args.IsArgSet("-version")) {
62-            strUsage += FormatParagraph(LicenseInfo()) + "\n";
63+            strUsage += FormatParagraph(LicenseInfo()) + "\n" + CopyrightInfo() + "\n";//from init.cpp

RandyMcMillan commented at 7:54 pm on December 4, 2020:

bitcoind.cpp uses the same strings that help and about use. LicenseInfo() and CopyrightInfo() are now refactored for reusability.

in src/clientversion.cpp:50 in e0ff8e263d outdated

46@@ -47,6 +47,11 @@ static std::string FormatVersion(int nVersion)
47     return strprintf("%d.%d.%d", nVersion / 10000, (nVersion / 100) % 100, nVersion % 100);
48 }
49 
50+std::string FormatVersion()

RandyMcMillan commented at 7:57 pm on December 4, 2020:

Returns a terse string for reusability. REF: https://github.com/bitcoin-core/gui/pull/140/commits/e0ff8e263dc96199385e31e481e64ad3a242fcd9#r536344384

RandyMcMillan commented at 8:22 pm on December 4, 2020: contributor

Updated default presentations:

Screen Shot 2020-12-04 at 3 19 07 PM

Screen Shot 2020-12-04 at 3 18 56 PM

in src/qt/bitcoin.qrc:1 in e0ff8e263d outdated

0@@ -1,4 +1,4 @@
1-<!DOCTYPE RCC><RCC version="1.0">
2+<RCC>

jonasschnelli commented at 8:24 am on December 7, 2020:

is this change necessary

RandyMcMillan commented at 11:05 pm on December 7, 2020:

Corrected - Qt should have never changed that. https://doc.qt.io/qt-5.12/qtxmlpatterns-schema-schema-qrc.html Unexpected behavior.

in src/qt/utilitydialog.cpp:50 in e0ff8e263d outdated

51+        QString aboutMessageInfoHTML = QString::fromStdString(AboutMessageInfo());
52         QString licenseInfoHTML = QString::fromStdString(LicenseInfo());
53         // Make URLs clickable
54         QRegExp uri("<(.*)>", Qt::CaseSensitive, QRegExp::RegExp2);
55         uri.setMinimal(true); // use non-greedy matching
56+        versionInfoHTML.replace(uri, "<a href=\"\\1\">\\1</a>");

jonasschnelli commented at 8:26 am on December 7, 2020:

why does it create a link here?

RandyMcMillan commented at 10:47 pm on December 7, 2020:

You are correct! This string no longer needs this transform. Awesome!

DrahtBot added the label Needs rebase on Dec 7, 2020

in src/bitcoind.cpp:64 in b66ded43fc outdated

66+        if (!args.IsArgSet("-version")) {
67+            strUsage += FormatParagraph(LicenseInfo()) + "\n"
68+                "\nUsage:  bitcoind [options]                     Start " PACKAGE_NAME "\n"
69+                "\n";
70+            strUsage += args.GetHelpMessage();
71         }

RandyMcMillan commented at 3:37 am on December 8, 2020:

Resolved conflict.

DrahtBot removed the label Needs rebase on Dec 8, 2020

RandyMcMillan renamed this:
~~about-view: clean up - Bitcoin branding~~
about:version:help clean up add Bitcoin branding
on Dec 8, 2020

test: feature_help.py test for essential elements fcfc21265e

about:version:help clean up add bitcoin branding 42b05fe3f7

RandyMcMillan marked this as a draft on Dec 8, 2020

Rspigler commented at 1:38 am on December 12, 2020: contributor

Whether I agree with the change or not, I don’t see how it can be appropriate to slip in a name change. Either the PR title should be changed, or a new PR created IMO. It also doesn’t make sense to me to have the name be Bitcoin Core on the loading screen, as well as Help->About Bitcoin Core yet then the about page say Bitcoin (without Core). It’s just more inconsistency.

We also have other issues underway on branding discussing this issue that aren’t cleared yet (#89, #100). There’s a lot of inconsistency. Bitcoin.org uses orange; bitcoincore.org uses both; bitcoin repo uses black; bitcoin-core repo uses orange. And now we’re making additional naming changes before any decisions have been made. Seems very messy.

RandyMcMillan commented at 6:35 pm on December 14, 2020: contributor

@Rspigler - I agree it is a pretty serious issue…

There is a lot to do - and lot of decisions to be made. This emphasizes the importance of a formal specification for branding/logo usage.

And yes…the scope of this PR has changed.

More importantly is - Working on the Gui has led me to believe there is a relatively easy work around to abstracting the Gui variables (PROJECT_NAME, etc..) from the build environment variables so Gui dev can progress and the plumbing can be refactored independently…

So once I know which direction to go concerning naming/branding/logo/etc… How to proceed should be clearer…

RandyMcMillan closed this on Jan 23, 2021

bitcoin-core locked this on Aug 16, 2022

about:version:help clean up add Bitcoin branding #140