Looking into how #129 would affect shortcuts in other languages, I noticed that many shortcuts are incorrect in other languages because the Transifex translation string contains a leading space character. I believe that a linter should be put in place to prevent this from happening in the future,
Affected Translations: bitcoin_ta.ts, bitcoin_ar.ts, bitcoin_uz@Cyrl.ts, bitcoin_sr.ts, bitcoin_ml.ts, bitcoin_es_CL.ts, bitcoin_nl.ts, bitcoin_ms.ts, bitcoin_lt.ts, bitcoin_es.ts, bitcoin_th.ts bitcoin_th.ts, bitcoin_te.ts, bitcoin_nb.ts, bitcoin_id.ts, bitcoin_hi.ts, bitcoin_fil.ts, bitcoin_el.ts, bitcoin_bg.ts
To Replicate:
- In order to
grepthe*.tsfiles we need to set them executable. Underqt/src/locale, run:
0chmod +x ./*.ts
- now
grepfor a matching&followed by a ‘space’ character
0grep -n "& " ./*.ts
- Optional: To get the files and number of occurrences (Sorted):
0grep -c "& " ./*.ts | grep -v ':0$' | sort -n -k2 -t:
- Below represents the output you will see. Here is a pastebin link of the full output. In this example, the shortcut for this command will be
spaceinstead ofG. This is incorrect and needs to be addressed.
0 <translation>& Gastar cambio no confirmado</translation>
- Using the above example: If we take a look at the transifex page we find that the string does in fact contain a leading
spacecharacter when it is not supposed to.