Detail view shows disconnected peer’s info #158

1. 
   hebasto commented at 7:58 am on December 20, 2020: member

   To reproduce

   1. select the “Peer” tab in the “Node window”

   2. choose any peer by clicking its row in the table, the detail view shows the peers’s info

   3. wait until the chosen peer disconnect

   Expected behavior

   The detail view stops showing the disconnected peer’s info (probably, show nothing).

   Actual behavior

   The detail view is still showing the disconnected peer’s info that is wrong.

   System information

   Bitcoin Core 0.21.0rc3

   Linux Mint 20

2. hebasto added the label Bug on Dec 20, 2020
3. 
   hebasto commented at 7:59 am on December 20, 2020: member

   cc @promag
4. 
   MarcoFalke commented at 8:25 am on December 20, 2020: contributor

   Is this a regression?
5. 
   hebasto commented at 3:21 pm on December 21, 2020: member

   ~Hmm, cannot reproduce this issue on regtest connecting some nodes each to other.~
6. 
   hebasto commented at 10:03 am on December 22, 2020: member

   Ok, I’ve managed to reproduce it:

   Steps to reproduce: use column sorting in peer table, and then let a peer to disconnect.

7. 
   hebasto commented at 10:36 am on December 22, 2020: member

   @MarcoFalke

   Is this a regression?

   No, it isn’t. The 0.20.0 has the same behavior.

8. 
   hebasto commented at 10:57 am on December 22, 2020: member

   Not observed on master(f4ac48d30a84906d648664c77bf839f012bebdbf) due to the #13. But peer table logic is still broken if the table is sorted, see #18.

   Closing.

9. hebasto closed this on Dec 22, 2020

   ---

10. bitcoin-core locked this on Feb 15, 2022

Contributors
hebasto MarcoFalke

Labels
Bug