Selected peer in the “Peers” tab gets unselected if any previous peer disconnects #160

issue hebasto openend this issue on December 22, 2020
  1. hebasto commented at 1:14 pm on December 22, 2020: member

    On master(209974d379e5c2f32f9f691c992a2fb58be2abf2) the selected peer in the “Peers” tab gets unselected if any previous peer (in the upper rows) disconnects.

    Step 1 – connected three peers, and “peerC” has been selected: Screenshot from 2020-12-22 15-04-19

    Step 2 – new connected peers (“peerD”) do not hurt: Screenshot from 2020-12-22 15-04-30

    Step 3 – but disconnection of any peer from upper rows (e.g., “peerB”) causes the loss of peer selection: Screenshot from 2020-12-22 15-05-28

  2. hebasto added the label Bug on Dec 22, 2020
  3. hebasto added the label UX on May 1, 2021
  4. jarolrod commented at 1:29 am on June 7, 2021: member

    This bug no longer operates in the way described. I have not investigated fully, but I believe that #18 fixed this bug as it is currently described. There is still a bug related to peer selection that exists and it is fixed by #164.

    New Bug: on master, if you select a peer, and a peer above it disconnects or is disconnected, the selection will slip to the next available peer.

    Select Peer 6 Disconnect Peer 0, Peer 7 is now selected
    Screen Shot 2021-06-06 at 9 17 11 PM Screen Shot 2021-06-06 at 9 17 48 PM

    As shown in the screenshots above, we start by selecting Peer 6: 149.248.3.82:38333. Peer 0 is then disconnected, our selection then slips to Peer 7: 88.99.101.67:38333.

    #164 Fixes New Bug: So while the bug has changed, I can confirm that #164 fixes this.

    Select Peer 9 Disconnect Peer 1, Peer 6 remains Selected
    pr-start pr-disconnect

    The screenshots above were taken on Linux on branch #164. We can see that we start with Peer 9: 149.248.3.82:38333, then we disconnect Peer 1. Our selection remains with Peer 9 and does not slip.

  5. hebasto closed this on Jun 7, 2021

  6. 2140data referenced this in commit 67fc2cc684 on Aug 3, 2022
  7. bitcoin-core locked this on Aug 16, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-22 02:20 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me