Save QSplitter state in QSettings #165

pull hebasto wants to merge 1 commits into bitcoin-core:master from hebasto:201225-geo changing 1 files +3 −0
  1. hebasto commented at 7:21 pm on December 25, 2020: member

    This PR adds the ability to save the QSplitter widget state in QSettings during shutdown, and restore it on startup.

    A user no longer needs to adjust the splitter every time :) DeepinScreenshot_select-area_20201225211422

  2. qt: Save QSplitter state in QSettings 90f9fc274b
  3. jonatack commented at 7:41 pm on December 25, 2020: contributor
    Great idea. Was complaining about this to myself just again today.
  4. jonatack approved
  5. jonatack commented at 7:57 pm on December 25, 2020: contributor
    ACK 90f9fc274bf69b33adea593146ff5d6793123781 this sets the “PeersTabSplitterSizes” value in the RPCConsole dtor and restores it in the RPCConsole ctor; tested in Debian with various split settings, tab open/close sequences, and shutdown methods, and the Peers window split state was faithfully maintained.
  6. jonasschnelli commented at 8:15 pm on December 28, 2020: contributor
    Good idea and just two lines of code. utACK 90f9fc274bf69b33adea593146ff5d6793123781
  7. jarolrod commented at 4:40 am on January 6, 2021: member
    Tested ACK on macOS Big Sur 11.1 with Qt 5.15.2. Works great and is a useful feature!
  8. luke-jr approved
  9. luke-jr commented at 5:45 pm on January 6, 2021: member
    utACK
  10. MarcoFalke merged this on Jan 7, 2021
  11. MarcoFalke closed this on Jan 7, 2021

  12. hebasto deleted the branch on Jan 7, 2021
  13. sidhujag referenced this in commit 22b9358918 on Jan 7, 2021
  14. luke-jr commented at 6:20 pm on January 19, 2021: member
    Note that we might need to change the setting name for each version that adds/removes columns :/
  15. bitcoin-core locked this on Aug 16, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-23 02:20 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me