This PR adds the ability to save the QSplitter widget state in QSettings during shutdown, and restore it on startup.
A user no longer needs to adjust the splitter every time :)
Save QSplitter state in QSettings #165
pull hebasto wants to merge 1 commits into bitcoin-core:master from hebasto:201225-geo changing 1 files +3 −0-
hebasto commented at 7:21 PM on December 25, 2020: member
-
qt: Save QSplitter state in QSettings 90f9fc274b
-
jonatack commented at 7:41 PM on December 25, 2020: contributor
Great idea. Was complaining about this to myself just again today.
- jonatack approved
-
jonatack commented at 7:57 PM on December 25, 2020: contributor
ACK 90f9fc274bf69b33adea593146ff5d6793123781 this sets the "PeersTabSplitterSizes" value in the RPCConsole dtor and restores it in the RPCConsole ctor; tested in Debian with various split settings, tab open/close sequences, and shutdown methods, and the Peers window split state was faithfully maintained.
-
jonasschnelli commented at 8:15 PM on December 28, 2020: contributor
Good idea and just two lines of code. utACK 90f9fc274bf69b33adea593146ff5d6793123781
-
jarolrod commented at 4:40 AM on January 6, 2021: member
Tested ACK on macOS Big Sur 11.1 with Qt 5.15.2. Works great and is a useful feature!
- luke-jr approved
-
luke-jr commented at 5:45 PM on January 6, 2021: member
utACK
- MarcoFalke merged this on Jan 7, 2021
- MarcoFalke closed this on Jan 7, 2021
- hebasto deleted the branch on Jan 7, 2021
- sidhujag referenced this in commit 22b9358918 on Jan 7, 2021
-
luke-jr commented at 6:20 PM on January 19, 2021: member
Note that we might need to change the setting name for each version that adds/removes columns :/
- bitcoin-core locked this on Aug 16, 2022
