raise helpMessageDialog #167

1. 
   RandyMcMillan commented at 9:59 pm on December 29, 2020: contributor

   the raise() method brings the helpMessageDialog to the top if it is obscured by another window.
2. in src/qt/bitcoingui.cpp:849 in 5d4964a92b outdated

   845@@ -846,6 +846,7 @@ void BitcoinGUI::showDebugWindowActivateConsole()
   846 void BitcoinGUI::showHelpMessageClicked()
   847 {
   848     helpMessageDialog->show();
   849+    helpMessageDialog->raise();//bring to top if obscured
   

   ---

   ---

   

   promag commented at 10:28 pm on December 29, 2020:

   Not sure if you are aware of GUIUtil::bringToFront(helpMessageDialog), seems the right call here ( and remove the above show()).

   ---

   

   RandyMcMillan commented at 4:02 pm on January 25, 2021:

   Thanks!
3. 
   hebasto commented at 4:30 pm on December 30, 2020: member

   @RandyMcMillan

   Mind providing steps to reproduce helpMessageDialog obscuring (as it is a top-level window, and it is activated via a menu item only)?

4. 
   jarolrod commented at 5:02 am on January 10, 2021: member

   No strong opinion, but I do not think this is needed.

   The help menu always shows on top, I cannot come up with a scenario where it is obfuscated. Furthermore, If the help window has been moved to the background by clicking on another window, clicking on Help -> Command-line Options will bring back the help window to the top.

5. 
   RandyMcMillan commented at 0:04 am on January 23, 2021: contributor

   i will post screen shots - maybe this is a macOS specific issue..
6. 
   RandyMcMillan commented at 0:34 am on January 23, 2021: contributor

   Maybe this is an “accessibility” issue and warrants an accessibility label - note that if the user is using tab-thru navigation. Once the window is presented and then obfuscated - using the nav bar again will not re-present the window.

   I think is is critical that we incorporate usability/accessibility considerations - I would hope that this gui centric fork allows for these very nuanced issues.

   Not everybody can use a mouse in gui applications. :)

   

   

7. 
   hebasto commented at 11:04 am on January 23, 2021: member

   Concept ACK.

   I can confirm this bug on macOS Big Sur 11.1 (20C69) + Homebrew’s Qt 5.15.2. @RandyMcMillan Do you mind using a more general approach suggested by @promag:

    0--- a/src/qt/bitcoingui.cpp
    1+++ b/src/qt/bitcoingui.cpp
    2@@ -845,7 +845,7 @@ void BitcoinGUI::showDebugWindowActivateConsole()
    3 
    4 void BitcoinGUI::showHelpMessageClicked()
    5 {
    6-    helpMessageDialog->show();
    7+    GUIUtil::bringToFront(helpMessageDialog);
    8 }
    9 
   10 #ifdef ENABLE_WALLET
   

8. raise helpMessageDialog 77114462f2
9. 
   RandyMcMillan commented at 4:01 pm on January 25, 2021: contributor

   Thanks for posting the snippet - saved a lot of time!
10. 
    promag commented at 5:21 pm on January 25, 2021: contributor

    Code review ACK 77114462f2328914b7a918f40776e522a0898e56.
11. hebasto approved
12. 
    hebasto commented at 10:19 pm on January 25, 2021: member

    ACK 77114462f2328914b7a918f40776e522a0898e56, tested on:

    • macOS Big Sur 11.1 (20C69) + Homebrew’s Qt 5.15.2
    • Linux Mint 20.1 + Cinnamon + Qt 5.12.8
13. 
    MarcoFalke commented at 6:53 am on January 26, 2021: contributor

    Does this need backport?
14. 
    hebasto commented at 8:39 am on January 26, 2021: member

    Does this need backport?

    Yes, I think, as it is a bugfix for macOS builds.

15. 
    MarcoFalke commented at 8:47 am on January 26, 2021: contributor

    ok, thanks. Will backport.
16. MarcoFalke merged this on Jan 26, 2021
17. MarcoFalke closed this on Jan 26, 2021

    ---

18. MarcoFalke referenced this in commit e2ebc8567a on Jan 26, 2021
19. 
    MarcoFalke commented at 8:52 am on January 26, 2021: contributor

    Backported in https://github.com/bitcoin/bitcoin/pull/20901
20. MarcoFalke added this to the milestone 0.21.1 on Jan 26, 2021
21. sidhujag referenced this in commit a2953bdbea on Jan 26, 2021
22. hebasto added the label Bug on Mar 6, 2021
23. hebasto added the label macOS on Mar 6, 2021
24. PastaPastaPasta referenced this in commit 9b876dc8b8 on Jun 27, 2021
25. PastaPastaPasta referenced this in commit d64cfbb240 on Jun 28, 2021
26. PastaPastaPasta referenced this in commit e1f476780f on Jun 29, 2021
27. PastaPastaPasta referenced this in commit fa4f0073db on Jul 1, 2021
28. PastaPastaPasta referenced this in commit 56bde915a6 on Jul 1, 2021
29. PastaPastaPasta referenced this in commit 9eb2df1518 on Jul 15, 2021
30. PastaPastaPasta referenced this in commit 403d2a0917 on Jul 16, 2021
31. apoelstra referenced this in commit 5d4db43893 on Sep 21, 2021
32. apoelstra referenced this in commit 176a257be2 on Sep 21, 2021
33. apoelstra referenced this in commit b514a872c3 on Sep 22, 2021
34. gades referenced this in commit e7c2087411 on May 9, 2022
35. bitcoin-core locked this on Aug 16, 2022

Contributors
RandyMcMillan promag hebasto jarolrod MarcoFalke

Labels
Bug macOS

Milestone
0.21.1