Note: When implementing a table based model,
rowCount()should return 0 when the parent is valid.
QAbstractItemModel::columnCount:
Note: When implementing a table based model,
columnCount()should return 0 when the parent is valid.
Follow Qt docs when implementing rowCount and columnCount #173
pull hebasto wants to merge 1 commits into bitcoin-core:master from hebasto:210102-table changing 5 files +30 −12-
hebasto commented at 7:47 PM on January 2, 2021: member
-
qt: Follow Qt docs when implementing rowCount and columnCount 195fcb53a0
-
jarolrod commented at 1:52 AM on January 6, 2021: member
Tested ACK 195fcb53a09e9b852544778a077727f81d31303e. Compiled and ran on macOS (Big Sur 11.1 and Catalina 10.15.7), Arch Linux, and FreeBSD. visually verified no weird effects with the
Address,Ban,Peer, andTransactiontables. As already stated, the code change brings us inline with what the QT Docs recommend. - luke-jr approved
-
luke-jr commented at 5:50 PM on January 6, 2021: member
utACK
- MarcoFalke merged this on Jan 7, 2021
- MarcoFalke closed this on Jan 7, 2021
- hebasto deleted the branch on Jan 7, 2021
- sidhujag referenced this in commit bc0cd9b795 on Jan 7, 2021
- PastaPastaPasta referenced this in commit 302b02d0d4 on Jun 27, 2021
- PastaPastaPasta referenced this in commit bd4c122b0f on Jun 28, 2021
- PastaPastaPasta referenced this in commit 5928bf5de6 on Jun 29, 2021
- PastaPastaPasta referenced this in commit 4582b2be12 on Jul 1, 2021
- PastaPastaPasta referenced this in commit 940d671ff4 on Jul 1, 2021
- PastaPastaPasta referenced this in commit 775922ef09 on Jul 15, 2021
- PastaPastaPasta referenced this in commit 87ea218fe2 on Jul 16, 2021
- gades referenced this in commit 2bb306d83a on May 24, 2022
- bitcoin-core locked this on Aug 16, 2022
