This change:
Fix https://github.com/bitcoin/bitcoin/issues/20826
Here are some screenshots with this PR with the minimum available width of the transaction list widget:
Looks good to me. The window is a lot bigger than it was before, and perhaps bigger than absolutely necessary but this is as small as I can make it:
For comparison, this is the ‘before’ shot:
Edit: the client window is made wider by this fix even for wallets that have no watchonly addresses. Is that intentional?
Is this for 0.21.1?
Yes, I think so, as it is a bugfix.
Yes I did, and I’ve included a screenshot of my settings below, but I ought to describe the issue more fully now that I’ve played around with it more.
I can reproduce the issue as follows: I have 2 wallets, one with watchonly addresses and one without. I have the one without show up by default when the client first loads, and it makes the client window 1109x842 pixels. If I then use the menu in the top right to switch to the wallet with watchonly addresses then the window resizes itself to 1329x842 to make room for the watchonly address balances as expected.
The problem is when I switch back to the first wallet. The window stays at its increased size and I can’t shrink it back. Some screenshots:
I have the following font settings:
This is the font I’m using.
This change (1) prevents overlapping date and amount strings,
and (2) guaranties that "eye" sign at the end of the watch-only
address/label is always visible.
ACK 1e31eca7bc01cbe68cef14768786a68e783ac11b
Tested on macOS 11.1 and Arch Linux both with Qt 5.15.2.
I was able to replicate the bug described by @dooglus on 5cf67f25a7d8cc75e1831aa37125f603f942b811. I can confirm that 1e31eca7bc01cbe68cef14768786a68e783ac11b now fixes this for me.
I cherry-picked your commits back to the v0.21.0rc4 tag and built. I saw a warning:
qt/walletframe.cpp: In member function ‘void WalletFrame::setCurrentWallet(WalletModel*)’:
qt/walletframe.cpp:110:9: warning: init-statement in selection statements only available with -std=c++17 or -std=gnu++17
if (WalletView* view_about_to_hide = currentWalletView(); view_about_to_hide != nullptr) {
^~~~~~~~~~
I don’t know if I’m supposed to be using a newer compiler but it wasn’t enforced when I ran the configure script. If this is intended to be backported to 0.21.1 maybe it shouldn’t use c++17 features.
Despite the warning the code works and I can now shrink the window back after switching to and back from the watchonly wallet.
Layouts of the hidden widgets, those are children of QStackedWidget,
could prevent to adjust the size of the parent widget in the
WalletFrame widget.
ACK af58f5b.
Now it resizes the window to make room for the watchonly addresses, allows me to shrink the window back when viewing a wallet without any such addresses, and builds without warnings when I backport it to v0.21.
re-ACK af58f5b12cea91467692dd4ae71d8cc916a608ed
Saw the same warning as @dooglus when patching 1e31eca7bc01cbe68cef14768786a68e783ac11b on 0.21rc4. Confirming that no warnings come up when patching af58f5b12cea91467692dd4ae71d8cc916a608ed on top of 0.21rc5. Tested on macOS 11.1 and Arch Linux both with Qt 5.15.2
ACK 1e31eca.
Now it resizes the window to make room for the watchonly addresses, allows me to shrink the window back when viewing a wallet without any such addresses, and builds without warnings when I backport it to v0.21.
Thanks for reviewing! Is it intentional the previous commit (not the current top) mentioned? :smile:
Milestone
0.21.1