User Agent header flickers when trying to resize any column #191

1. 
   hebasto commented at 2:12 pm on January 20, 2021: member

   

   System: Linux Mint 20.1 + Cinnamon DE + Qt 5.12.8

2. hebasto added the label Bug on Jan 20, 2021
3. 
   jarolrod commented at 4:31 pm on January 20, 2021: member

   Confirming the same happens on macOS 11.1 + Qt 5.15.2
4. 
   RandyMcMillan commented at 6:06 pm on January 20, 2021: contributor

   Appending a “bumper” as the last column of the peertablemodel should fix this issue.

   In this stale PR - I found that was a reasonable solution.

   https://github.com/bitcoin-core/gui/pull/135/files#diff-e721b02fefce2a90ae95da0841adfdcc610ffccf93236ef236f81c1baead8e01R112

5. 
   hebasto commented at 6:51 pm on January 20, 2021: member

   Appending a “bumper” as the last column of the peertablemodel should fix this issue.

   In this stale PR - I found that was a reasonable solution.

   https://github.com/bitcoin-core/gui/pull/135/files#diff-e721b02fefce2a90ae95da0841adfdcc610ffccf93236ef236f81c1baead8e01R112 @RandyMcMillan Could that change be separated from #135 into its own bugfix PR?

6. 
   RandyMcMillan commented at 6:52 pm on January 20, 2021: contributor

   I will take a look - the PR may be too stale.
7. 
   RandyMcMillan commented at 6:58 pm on January 20, 2021: contributor

   I should have a fix in a few minutes.
8. 
   hebasto commented at 6:59 pm on January 20, 2021: member

   @RandyMcMillan Another option is to fix the TableViewLastColumnResizingFixer class.

   EDIT: it seems TableViewLastColumnResizingFixer is not used here…

9. 
   hebasto commented at 0:19 am on January 21, 2021: member

   Interesting that the banlistWidget has the same properties as the peerWidget, but the former works without flickering.
10. 
    hebasto commented at 0:59 am on January 21, 2021: member

    It appears that this bug is fixed in f73d340abeedf7e583fe9b2a8b3685a745a9199e (#164). @jarolrod Could you check it please?
11. 
    jarolrod commented at 1:41 am on January 21, 2021: member

    @hebasto testing now

    One note about this bug is that it happens if that User Agent column is a certain size. If I resize the User Agent column to be smaller, then it doesn’t happen when I got to resize other columns. But, if I bring it back to its original size, the bug shows up.

    

12. 
    jarolrod commented at 1:59 am on January 21, 2021: member

    @hebasto confirming that #164 fixes this bug, seems that your refactoring of PeerTableModel::refresh() did the job
13. hebasto closed this on Jun 7, 2021

    ---

14. bitcoin-core locked this on Aug 16, 2022

Contributors
hebasto jarolrod RandyMcMillan

Labels
Bug