@hebasto - here is a barebones fix for #191 We can tweak the presentation in a follow up PR.
fix for #191 #192
pull RandyMcMillan wants to merge 1 commits into bitcoin-core:master from RandyMcMillan:191 changing 2 files +4 −3-
RandyMcMillan commented at 7:07 PM on January 20, 2021: contributor
-
fix for #191 0e7f0a8501
-
hebasto commented at 7:12 PM on January 20, 2021: member
Thanks for fixing!
- Did you find out the reason of head flickering?
- Could using of
GUIUtil::TableViewLastColumnResizingFixerbe a better option as it is used in other places of the GUI? - Do you mind dropping
@from the PR description?
-
jarolrod commented at 8:55 PM on January 20, 2021: member
This PR does not fix #191
It instead creates a new column in the Peer Table model. A fix to this should not hack on a new column so that the
User Agentcolumn does not glitch. Perhaps a refactor that creates aPeerTableModelViewwhich makes use ofTableViewLastColumnResizingFixeris more appropriate.PR: Creates a new column to the right of
User Agent<img width="898" alt="Screen Shot 2021-01-20 at 3 51 23 PM" src="https://user-images.githubusercontent.com/23396902/105233279-a2f18c00-5b37-11eb-8dd9-336b506a6153.png"> -
RandyMcMillan commented at 11:00 PM on January 20, 2021: contributor
@jarolrod - It sounds like you have the motivation to implement a proper solution. I will be excited to see how you refactor this into a proper MVC implementation. I will be ecstatic to see it actually get merged! Happy coding!
- RandyMcMillan closed this on Jan 20, 2021
-
jarolrod commented at 12:32 AM on January 21, 2021: member
@RandyMcMillan was just relaying what I found while reviewing the PR. Wasn't trying to discourage you in anyway or come off as rude.
- bitcoin-core locked this on Aug 16, 2022
