peers-tab: bug fix right panel toggle #202

pull RandyMcMillan wants to merge 1 commits into bitcoin-core:master from RandyMcMillan:peers-tab-sidepanel changing 2 files +3 −3

RandyMcMillan commented at 1:42 AM on January 29, 2021: contributor

Initial Presentation:

When node row selected - panel is presented:

When network disabled - right panel is hidden:
peers-tab: bug fix right panel toggle 8353e8cecc
luke-jr commented at 1:45 AM on January 29, 2021: member

What is this fixing?
RandyMcMillan commented at 1:54 AM on January 29, 2021: contributor

Hiding the detailWidget is incorrect - hiding the right panel of the splitter view is the correct usage of the splitter view. This change uses the splitter view correctly.

Running the code will make what the change addresses readily apparent.
jarolrod commented at 7:37 PM on February 9, 2021: member

ACK 8353e8cecc3e34a8699b53849df0adab622c1c14

This is a welcome change as it makes more efficient use of the peers tab window. On master the peer detail widget is always shown even if no peer has been selected. This pr introduces a toggle feature where the peer detail widget will only pop up when a peer has been selected.

Checked and confirmed that when multiple peers are selected the peer widget will still hide (introduced in #13)
jonatack commented at 3:01 PM on February 10, 2021: contributor

ACK 8353e8cecc3e34a8699b53849df0adab622c1c14 tested rebased on current master. Behavior is initially a bit surprising but this would allow more columns to be added to the peers tab window. Verified that selecting more than one peer, clicking on a column header, or running disconnectnode "" <currently-selected-peer-id> in the console (or on the CLI with the -server startup option) returns the window to its full size. If this is merged, it might be nice to have an obvious way to close the details area like a clickable "close this" icon in the upper left corner of the area.
RandyMcMillan commented at 6:54 PM on February 10, 2021: contributor

@jonatack - thank you! yes - this is the goal! Part of a larger common initiative to make the peers tab contain more info and be more useful - a better use of GUI real estate. :) This PR is sparse - as to not break other work being done. :)
Talkless approved
Talkless commented at 4:26 PM on February 21, 2021: none

tACK 8353e8cecc3e34a8699b53849df0adab622c1c14, tested on Debian Sid. Made bitcoind connect to bitcoin-qt with the PR changes, and after I quit the bitcoind instance, right panel do disappear, compared to the previous commit where it didn't.
MarcoFalke merged this on Feb 22, 2021
MarcoFalke closed this on Feb 22, 2021
hebasto commented at 3:48 PM on February 22, 2021: member

A UX note: to clear selection use Ctrl + click (actually, it inverses selection).
sidhujag referenced this in commit f3874b9fb1 on Feb 22, 2021
hebasto commented at 10:17 AM on February 23, 2021: member

When no peer is selected, and one calls a context menu, it causes the peer selection with a layout change.

I found such a behavior distracting.
gwillen referenced this in commit 01e64b2225 on Jun 28, 2022
bitcoin-core locked this on Aug 16, 2022

Contributors

Linked (view graph)

#289 Add "Direction" column to peers tab