Display plain “Inbound” in peer details #203
pull jonatack wants to merge 1 commits into bitcoin-core:master from jonatack:display-plain-inbound-and-add-release-notes changing 3 files +5 −5-
jonatack commented at 6:26 pm on January 30, 2021: contributorAlternative version to #201.
-
in doc/release-notes-162-163.md:15 in ff8afeb222 outdated
10+ Peer Id and Address, respectively. (#162) 11+ 12+- In the Peers window, the Direction field in the peer details area is replaced 13+ by a Connection Type field that displays both the direction and the type of 14+ peer connection. For more info, place the cursor over the field to see the 15+ detailed tooltip. (#163)
MarcoFalke commented at 7:02 pm on January 30, 2021:Not sure if we need this. Most people don’t read the release notes and making them longer with gui changes, which are (should aim to be) self-explanatory in most cases, doesn’t make them more attractive. No strong opinion, though.
jonatack commented at 7:26 pm on January 30, 2021:Yes, I wasn’t sure either. I also didn’t check if the GUI PR numbers work with the scripts.
jonatack commented at 7:30 pm on January 30, 2021:Dropped the release notes, can add them later on if anyone wants.MarcoFalke approvedMarcoFalke commented at 7:03 pm on January 30, 2021: contributorreview ACK ff8afeb22296460ab4e04eaab48ce0f89f8036bf
Thanks
gui: display plain "Inbound" in peer details 506e6585a5jonatack renamed this:
gui: display plain "Inbound" in peer details, add #162/#163 release notes
gui: display plain "Inbound" in peer details
on Jan 30, 2021jonatack force-pushed on Jan 30, 2021jonatack renamed this:
gui: display plain "Inbound" in peer details
Display plain "Inbound" in peer details
on Jan 30, 2021MarcoFalke commented at 7:39 am on January 31, 2021: contributorACK 506e6585a54818d0613a067f91c0bac2f308a48cjonatack commented at 4:47 pm on February 5, 2021: contributor-netinfo
on master is now aligned with this change:jonasschnelli approvedjonasschnelli commented at 5:48 pm on February 5, 2021: contributorutACK 506e6585a54818d0613a067f91c0bac2f308a48cjonasschnelli merged this on Feb 5, 2021jonasschnelli closed this on Feb 5, 2021
jonatack deleted the branch on Feb 5, 2021sidhujag referenced this in commit 8fb2f17760 on Feb 5, 2021lehuuhieu7777 commented at 10:51 am on February 6, 2021: nonebitcoin-core locked this on Aug 16, 2022
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 21:20 UTC
This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 21:20 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me