Drop buggy TableViewLastColumnResizingFixer class #204

pull hebasto wants to merge 1 commits into bitcoin-core:master from hebasto:210131-resize changing 6 files +4 −182
  1. hebasto commented at 4:11 pm on January 31, 2021: member

    In Qt 5 the last column resizing with dragging its left edge works out-of-the-box.

    The current TableViewLastColumnResizingFixer implementation could put the last column content out of the view port and confuse a user: Screenshot from 2021-01-31 18-04-32

    Historical context:

    #205 is a nice addition.

  2. qt: Drop buggy TableViewLastColumnResizingFixer class
    In Qt 5 the last column resizing with dragging its left edge works
    out-of-the-box.
    The current TableViewLastColumnResizingFixer implementation could put
    the last column content out of the view port and confuse a user.
    3913d1e8c1
  3. jarolrod commented at 8:23 am on February 8, 2021: member

    ACK 3913d1e8c1f604bdd622d5e81e5077ef52b30466, tested on macOS 11.1 Qt 5.15.2

    On master, when you resize, the last column can go out of the view-port. This can be confusing because there’s no contextual clues that there is more to see by scrolling to the right. This PR add this contextual awareness by showing a scrollbar. Below are screenshots showing this behavior:

    Master: Last column can go out of view port while resizing

    PR: scrollbar gives contextual awareness that I can scroll right to see more

  4. hebasto commented at 7:48 am on February 21, 2021: member
    @promag @jonatack Do you mind reviewing this PR?
  5. Talkless approved
  6. Talkless commented at 3:24 pm on February 21, 2021: none
    tACK 3913d1e8c1f604bdd622d5e81e5077ef52b30466, tested on Debian Sid. Can confirm that behavior in previous commit does not produce scroll bar, last column gets “hidden”. This PR makes clear that there’s more to see in the view.
  7. in src/qt/receivecoinsdialog.cpp:87 in 3913d1e8c1
    83         tableView->setSelectionBehavior(QAbstractItemView::SelectRows);
    84         tableView->setSelectionMode(QAbstractItemView::ContiguousSelection);
    85         tableView->setColumnWidth(RecentRequestsTableModel::Date, DATE_COLUMN_WIDTH);
    86         tableView->setColumnWidth(RecentRequestsTableModel::Label, LABEL_COLUMN_WIDTH);
    87         tableView->setColumnWidth(RecentRequestsTableModel::Amount, AMOUNT_MINIMUM_COLUMN_WIDTH);
    88+        tableView->horizontalHeader()->setMinimumSectionSize(MINIMUM_COLUMN_WIDTH);
    


    promag commented at 6:41 pm on February 21, 2021:
    I’ve removed this and didn’t notice differences, at least on macos.

    hebasto commented at 7:42 pm on February 21, 2021:

    It prevents Screenshot from 2021-02-21 21-41-20

    at least on Linux :)

  8. promag commented at 6:43 pm on February 21, 2021: contributor
    Tested ACK 3913d1e8c1f604bdd622d5e81e5077ef52b30466 on macos.
  9. MarcoFalke merged this on Feb 22, 2021
  10. MarcoFalke closed this on Feb 22, 2021

  11. MarcoFalke referenced this in commit 0e9596c860 on Feb 22, 2021
  12. hebasto deleted the branch on Feb 22, 2021
  13. sidhujag referenced this in commit c7a0f8cbd4 on Feb 22, 2021
  14. gwillen referenced this in commit 2b9625fa81 on Jun 28, 2022
  15. bitcoin-core locked this on Aug 16, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-23 02:20 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me