“Label” for receiving addresses, and its position in context menu is misleading #209

1. 
   surak commented at 1:43 pm on February 2, 2021: none

   Transactions have a field “label”. It makes it look like each transaction can be labeled (which is bitcoin parlay seems to be a comment), when it’s actually a label of the receiving address. This is misleading and can be clarified.

   This is not a new issue: https://github.com/bitcoin/bitcoin/pull/5905 , but a new but was created (and closed) on bitcoin-core about that recently: https://github.com/bitcoin/bitcoin/issues/21057

   Even though a comment field would be very welcome, this issue here is simply about the confusion created by the understanding of the term label on the GUI.

   Actual behavior

   When one sets a label, it sets a label for the receiving address. It’s not clear until the moment when one clicks “edit label” and a dialog appears what that means.

   To reproduce

   Right-click a transaction, choose “edit label” - it seems a unfortunate place for such a thing, since other menu items are for that transaction and not for the receiving address.

   System information

   Bitcoin-QT 0.21.0 for Mac OS.

2. surak added the label Bug on Feb 2, 2021
3. 
   jonasschnelli commented at 7:33 am on February 4, 2021: contributor

   Agree that this is confusing. Would removing the “edit label” action in the transaction context menu be more an option? I guess one trying to edit the labels can still use the address books
4. 
   MarcoFalke commented at 7:38 am on February 4, 2021: contributor

   Indeed, as a first step it could make sense to remove the per-tx “edit label” because it is really per-address. As a second step, https://github.com/bitcoin/bitcoin/pull/5905 could be rebased.
5. MarcoFalke added the label Feature on Feb 4, 2021
6. MarcoFalke added the label good first issue on Feb 4, 2021
7. MarcoFalke removed the label Bug on Feb 4, 2021
8. 
   jarolrod commented at 11:28 pm on February 17, 2021: member

   When you click Edit Label you are really editing the label for the address type. Looking at the code, the Edit Label action determines what the address type is and brings up the associated mechanism. If we are to remove the Edit Label action from the transactionview, we must ensure there’s another way to edit the label

   For a Sending address, you can currently edit the label in the Address Book of the send tab.

   For a Receiving Address, it seems the only place to edit the label would be in the transactionview of the Transactions tab as the received address view lacks an Edit Label action in its context menu. An Edit Label action should be added to the Receive Tab.

9. 
   jarolrod commented at 6:38 pm on February 18, 2021: member

   Documenting that this issue is related to https://github.com/bitcoin/bitcoin/issues/1168
10. MarcoFalke referenced this in commit 5e4a3ca2f4 on Feb 22, 2021
11. sidhujag referenced this in commit cf2b290581 on Feb 22, 2021
12. 
    MarcoFalke commented at 8:00 am on February 24, 2021: contributor

    Fixed in #223
13. MarcoFalke closed this on Feb 24, 2021

    ---

14. MarcoFalke removed the label good first issue on Feb 24, 2021
15. PastaPastaPasta referenced this in commit fdc34f6aba on Sep 17, 2021
16. PastaPastaPasta referenced this in commit d3fc1a51e3 on Sep 19, 2021
17. thelazier referenced this in commit afd8d632e6 on Sep 25, 2021
18. bitcoin-core locked this on Aug 16, 2022

Contributors
surak jonasschnelli MarcoFalke jarolrod

Labels
Feature