Update pruning tooltip, original author BitcoinErrorLog #21

1. 
   fluffypony commented at 1:20 pm on July 2, 2020: contributor

   Squashed commits from BitcoinErrorLog at his request, per the original discussion on #15: this tooltip has been adjusted to be more user-friendly and reflect what the net effect of pruning is for the user.
2. Update pruning tooltip, original author BitcoinErrorLog 2fc5efc55c
3. 
   jnewbery commented at 2:59 pm on July 2, 2020: contributor

   Thanks for the PR @fluffypony ! Can you change your PR description to describe what this change does? The maintainers’ merge tool includes the PR description in the merge commit, so unless BitcoinErrorLog wants to be bombarded with notifications from github for this, you should remove his handle.
4. 
   fluffypony commented at 3:03 pm on July 2, 2020: contributor

   @jnewbery done
5. 
   fluffypony commented at 3:04 pm on July 2, 2020: contributor

   Also let me know if you want me to flip it round and put what it does at the beginning of the description, and attribution notes at the end.
6. 
   harding commented at 3:05 pm on July 2, 2020: contributor

   Untested ACK 2fc5efc55c886f1b874ce6cd02c9082b5bb6435a
7. 
   Sjors commented at 4:51 pm on July 2, 2020: member

   utACK 2fc5efc55c886f1b874ce6cd02c9082b5bb6435a and welcome to the dark side!

   You could also use git commit --author

8. 
   fluffypony commented at 4:56 pm on July 2, 2020: contributor

   @Sjors Thanks! I was going to, but I GPG-sign my commits, so I thought it would be a little odd to have BEL as the author but with my GPG sig;)
9. 
   Sjors commented at 5:01 pm on July 2, 2020: member

   Another approach is to put Co-Authored-By: in the commit message (to be clear: no need to).
10. 
    Rspigler commented at 5:29 am on July 3, 2020: contributor

    I think it is very important that users know pruning disables some advanced features. Otherwise, why not always enable pruning? Rerunning IBD is a hassle - currently, users are only warned that it will happen if reverted, but not why they may have to revert.
11. 
    fluffypony commented at 5:59 am on July 3, 2020: contributor

    @Rspigler there’s been enough bike-shedding on the previous PR; I would suggest this get merged so that feedback can be elicited from actual users, and then the tooltip can be iterated on.
12. 
    Rspigler commented at 10:03 pm on July 3, 2020: contributor

    Feedback already has been brought by users, this has been a requested change: https://twitter.com/mikeinspace/status/1278453115835035653
13. 
    fluffypony commented at 7:03 am on July 4, 2020: contributor

    Ehhhh I’m skeptical that users running the Bitcoin Core GUI are hooking a block explorer up to it. I agree that such warnings are warranted in the CLI and documentation. Is there any functionality within the GUI that is affected by enabling pruning? That should be noted. Some externality is (generally speaking) not the concern of this piece of software.
14. 
    fluffypony commented at 7:04 am on July 4, 2020: contributor

    To add: any additional software you’re trying to hook into Bitcoin will come with it’s own instructions, which includes a note on disabling pruning (see Electrum Personal Server, for instance, which actually works with pruning and notes when you’d want to leave it disabled).
15. 
    harding commented at 7:36 am on July 4, 2020: contributor

    AFAIK, the only thing pruning disables in the GUI is the ability to close a wallet, keep it closed until the last block it saw has dropped beyond the prune horizon (plus one more block), and then open up that wallet again. We already have a warning for that case:

    

    (I’m not counting RPCs affected by pruning that are technically available in the GUI via its RPC console.)

    I personally think it’s not particularly useful to say “disables some advanced features” without also providing the user with a list of those features—and that’s getting beyond the amount of information a tooltip should probably contain. Additionally, although re-downloading blocks is certainly very annoying, anyone who did it once can probably do it again without too much issue. I don’t think we need to worry too much about it, although anyone writing extended documentation about pruning should certainly consider describing the tradeoffs.

16. 
    fluffypony commented at 9:15 am on July 4, 2020: contributor

    @harding thanks for the extra colour - fully agree that extended docs should go into detail about what may be affected by pruning, and that it’s out-of-scope for the tooltip.
17. 
    Rspigler commented at 9:55 pm on July 4, 2020: contributor

    I think that’s a very good point you brought up, pruning doesn’t affect functionality /within the GUI/. Warnings in the CLI and documentation should cover it.
18. 
    luke-jr commented at 8:43 pm on July 31, 2020: member

    No mention of lost functionality at all?

    This impacts the ability to restore wallet backups…

19. 
    harding commented at 12:25 pm on August 5, 2020: contributor

    @luke-jr if you lost your original wallet file, you probably also lost your chainstate, so you probably need to IBD again anyway.
20. 
    jonasschnelli commented at 9:24 am on October 23, 2020: contributor

    ACK 2fc5efc55c886f1b874ce6cd02c9082b5bb6435a Since translation freeze for 0.21.0 happened already, we have to postpone this for 0.22
21. jonasschnelli added this to the milestone 0.22.0 on Oct 23, 2020
22. laanwj referenced this in commit 924a4ff7eb on Oct 29, 2020
23. jonasschnelli merged this on Nov 20, 2020
24. jonasschnelli closed this on Nov 20, 2020

    ---

25. sidhujag referenced this in commit 6fe0f31ff4 on Nov 20, 2020
26. apoelstra referenced this in commit 7c51c72ac4 on Dec 3, 2020
27. gwillen referenced this in commit 1dfa6369bc on Mar 23, 2021
28. MarcoFalke referenced this in commit bce09da122 on Apr 28, 2021
29. MarcoFalke referenced this in commit eb9a1fe037 on May 7, 2021
30. MarcoFalke referenced this in commit c857148636 on May 15, 2021
31. PastaPastaPasta referenced this in commit afb18e7c75 on Jun 27, 2021
32. PastaPastaPasta referenced this in commit b9a2e14506 on Jun 28, 2021
33. PastaPastaPasta referenced this in commit 93eda31dfd on Jun 29, 2021
34. PastaPastaPasta referenced this in commit 5321f41df2 on Jul 1, 2021
35. PastaPastaPasta referenced this in commit 3abe470250 on Jul 1, 2021
36. PastaPastaPasta referenced this in commit a8f3e4ccdc on Jul 15, 2021
37. PastaPastaPasta referenced this in commit 76b337b35f on Jul 16, 2021
38. gabriel-bjg referenced this in commit 99ffdaad13 on Jul 16, 2021
39. bitcoin-core locked this on Feb 15, 2022

Contributors
fluffypony jnewbery harding Sjors Rspigler luke-jr jonasschnelli

Milestone
22.0