This PR removes the Edit Label action from the transactionview context menu. Since the Edit Label action will no longer be utilized in the transactionview, the Edit Label function logic is also removed.
| Master | PR |
|---|---|
Among the context menu actions for each transaction in the transactionview is the Edit Label action.
While all other actions apply directly to the selected transaction, the Edit Label action applies to the selected transaction’s address. As documented in issue #209 and #1168 , this is an “unfortunate” placement for such an action. The current placement creates a confusing UX scenario where the outcome of the action is ambiguous.
Example of Ambiguous Behavior:
The context menu gives the wrong impression that the Edit Label action will edit a Label for the specific transaction that has been right-clicked on. This impression can be because all other actions in this menu will relate to the specific transaction and the misconception between Comment and Label.
Let’s say I wanted to give the transaction selected in the screenshot above a comment of “2-17[17:43]”. Given all the context clues, it will be reasonable to assume that the Edit Label function will give a label to this transaction. Instead, it edits the Label for the address behind this transaction. Thus, changing the Label for all transactions associated with this address.
Maintaining Edit Label Functionality:
The action of Editing a Label should instead be reserved for the respective address tables of the Send and Receive tabs. As documented in this comment, Edit Label is currently implemented in the Send tab and is missing in the Receive tab. A follow-up PR can add the Edit Label functionality to the Receive tab.
