Support building without embedded monospace font #216
pull luke-jr wants to merge 2 commits into bitcoin-core:master from luke-jr:optional_font changing 7 files +57 −5-
luke-jr commented at 8:08 pm on February 22, 2021: member
-
hebasto commented at 8:22 pm on February 22, 2021: memberConcept ACK. Maybe a bit more motivation for the second commit description?
-
luke-jr commented at 9:09 pm on February 22, 2021: member
A few motivations for the 2nd commit:
- Most non-macOS/Windows systems already have a decent monospace font installed.
- Only macOS/Windows appear to have denied users the option to configure their monospace font.
- Embedding fonts is generally undesirable and non-standard on *nix platforms.
-
Support building without embedded monospace font 1e9ada3965
-
configure: Disable embedded font by default, except for macOS/Windows 1ada6fb446
-
luke-jr force-pushed on Feb 23, 2021
-
hebasto commented at 1:30 pm on February 25, 2021: member
As this PR changes the build stuff, should it be moved into the main repo?
(The GUI repo doesn’t even have the “Build system” label)
-
DrahtBot commented at 11:20 am on October 9, 2021: contributor
🐙 This pull request conflicts with the target branch and needs rebase.
Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a “draft”.
-
DrahtBot added the label Needs rebase on Oct 9, 2021
-
luke-jr commented at 0:01 am on October 12, 2021: member
This should probably still be done, but I’m cutting it due to lack of time to figure out why it isn’t working.
Suggest “Up for grabs” label.
-
luke-jr closed this on Oct 12, 2021
-
hebasto removed the label Needs rebase on Oct 12, 2021
-
hebasto added the label Up for grabs on Oct 12, 2021
-
bitcoin-core locked this on Oct 12, 2022
Labels
Up for grabs
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-01 02:20 UTC
This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-01 02:20 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me