Support building without embedded monospace font #216

pull luke-jr wants to merge 2 commits into bitcoin-core:master from luke-jr:optional_font changing 7 files +57 −5
  1. luke-jr commented at 8:08 pm on February 22, 2021: member
  2. hebasto commented at 8:22 pm on February 22, 2021: member
    Concept ACK. Maybe a bit more motivation for the second commit description?
  3. luke-jr commented at 9:09 pm on February 22, 2021: member

    A few motivations for the 2nd commit:

    • Most non-macOS/Windows systems already have a decent monospace font installed.
    • Only macOS/Windows appear to have denied users the option to configure their monospace font.
    • Embedding fonts is generally undesirable and non-standard on *nix platforms.
  4. Support building without embedded monospace font 1e9ada3965
  5. configure: Disable embedded font by default, except for macOS/Windows 1ada6fb446
  6. luke-jr force-pushed on Feb 23, 2021
  7. hebasto commented at 1:30 pm on February 25, 2021: member

    As this PR changes the build stuff, should it be moved into the main repo?

    (The GUI repo doesn’t even have the “Build system” label)

  8. DrahtBot commented at 11:20 am on October 9, 2021: contributor

    🐙 This pull request conflicts with the target branch and needs rebase.

    Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a “draft”.

  9. DrahtBot added the label Needs rebase on Oct 9, 2021
  10. luke-jr commented at 0:01 am on October 12, 2021: member

    This should probably still be done, but I’m cutting it due to lack of time to figure out why it isn’t working.

    Suggest “Up for grabs” label.

  11. luke-jr closed this on Oct 12, 2021

  12. hebasto removed the label Needs rebase on Oct 12, 2021
  13. hebasto added the label Up for grabs on Oct 12, 2021
  14. bitcoin-core locked this on Oct 12, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-01 02:20 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me