qt: Make warning label look clickable #217

pull jarolrod wants to merge 1 commits into bitcoin-core:master from jarolrod:warning-look-like-button changing 1 files +2 −8
  1. jarolrod commented at 10:20 pm on February 22, 2021: member

    The warning icon on the overview page indicates that there is something important the user should know about, but a user may not be aware that they can click it because, on master, the warning label does not look clickable. As detailed in issue #23, the reason to make it look clickable is that it if they “had a more clickable-appearance (borders or beveled button edges) it could help users more quickly understand what they are being alerted to.”

    This PR removes the flat property from both QPushButton’s to make them look like a button, and therefore clickable. Furthermore, it updates the Maximum Width to 45 to fix the small hit-box issue outlined in issue #215.

    Below are screenshots showing how the warning icon looks under master and this PR:

    macOS 11.1: Qt 5.15

    Master PR

    Ubuntu 20.04: Qt 5.12

    Master PR
    Screen Shot 2021-02-22 at 4 12 54 PM

    Closes #23 Closes #215

  2. qt: Make warning label look clickable
    The warning label shown on the overview page does not look clickable.
    This PR makes the warning label look clickable by removing the 'flat' property.
    Additionally, the Maximum Width is updated to fix the small hit-box issue.
    67c59ae479
  3. leonardojobim commented at 5:26 am on February 23, 2021: none
    Concept ACK. It makes easier for the users to realize the warning label is clickable.
  4. luke-jr approved
  5. luke-jr commented at 5:04 pm on February 24, 2021: member
    utACK
  6. Talkless approved
  7. Talkless commented at 7:03 pm on March 4, 2021: none
    tACK 67c59ae4793b1a5ebe0c4c542abf3c095e6a658b, tested on Debian Sid. Does look as expected.
  8. MarcoFalke merged this on Mar 5, 2021
  9. MarcoFalke closed this on Mar 5, 2021

  10. sidhujag referenced this in commit 4b4384d22d on Mar 5, 2021
  11. jarolrod deleted the branch on Mar 8, 2021
  12. gwillen referenced this in commit fc3debb274 on Jun 28, 2022
  13. bitcoin-core locked this on Aug 16, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-23 11:20 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me