https://github.com/bitcoin/bitcoin/issues/11168 is not fixed by https://github.com/bitcoin/bitcoin/pull/11169 completely, as users are allowed to right click on the menu bar:
This PR moves the context menu prohibition from QToolBar instance to its parent BitcoinGUI instance, which is derived from QMainWindow.
By default, a popup menu contains checkable entries for the toolbars
and dock widgets present in the main window. This allows users to
accidentally hide the toolbar.
ACK ca5bd1c8e5fee29a3c2f0a3fbc879ee74f892266, tested on Ubuntu 20.04 Qt 5.12. Confirming that I can replicate the behavior described on master and this PR fixes it.
The question is: "Is there a use case for disabling tabs?" I would lean towards no. To me, it doesn't make sense to allow a user to toggle the visibility of the tabs.
tACK https://github.com/bitcoin-core/gui/pull/219/commits/ca5bd1c8e5fee29a3c2f0a3fbc879ee74f892266
Tested on Ubuntu 20.04 Qt 5.12.8.
I also confirm that context menu is displayed on master branch but it does not happen on the branch of this PR.
Concept ACK, but I don't understand why the toolbar inherits this prohibition and other widgets (where we want a context menu) don't...
I don't understand why the toolbar inherits this prohibition and other widgets (where we want a context menu) don't...
Probably, due to the fact that QMainWindow has its own layout which a QMenuBar belongs to.