qt: Re-add and rename transaction “Edit Label” action #223

1. 
   laanwj commented at 7:38 am on February 24, 2021: member

   This reverts PR #211.

   I disagree with this change, I use the functionality a lot, it was the primary way I used to organize and edit transactions labels and am sad to see this go.

   you can edit a sending address in the send tab Address Book

   Using the address book should not be encouraged at all! A while ago it was even proposed to remove it. There’s rarely need to scroll through all historical addresses used and unused. The transaction list does just fine for this.

   While all other actions apply directly to the selected transaction, the Edit Label action applies to the selected transaction’s address.

   In practice when bitcoin is used in the commonly advised way, generate a new address for each transaction, those are equivalent though.

   I doubt I (and luke-jr) will be the only users that will stumblle on this. Further discussion here: #211 (comment)

2. Revert "qt: Remove Transactionview Edit Label Action"

   This reverts commit 8f9644890a167a093d95ecef1f12a20dce1bc581.

   22664d6287
3. 
   sipa commented at 7:42 am on February 24, 2021: contributor

   I have little opinion on whether the functionality should exist at all, but I think the original change was motivated by confusion about what the feature does.

   Just renaming it to “Change address label” would mitigate that just as well.

4. 
   laanwj commented at 7:45 am on February 24, 2021: member

   Just renaming it to “Change address label” would mitigate that just as well.

   Sounds good to me, I can include that change here if there’s agreement on that.

5. 
   hebasto commented at 7:45 am on February 24, 2021: member

   Original suggestions:

   • #209 (comment) by @jonasschnelli
   • #209 (comment) by @MarcoFalke

   Just renaming it to “Change address label” would mitigate that just as well.

   I like this suggestion.

6. 
   jarolrod commented at 7:47 am on February 24, 2021: member

   Just renaming it to “Change address label” would mitigate that just as well.

   This is good, keeps the functionality while being more informative as to the outcome. Very democratic :)

7. qt: Rename "Edit label" to "Edit address label"

   This makes it more specific what the action refers to.
   (Suggested by Pieter Wuille)

   5440c07457
8. laanwj renamed this:
   qt: Re-add transaction "Edit Label" Action
   qt: Re-add and rename transaction "Edit Label" action
   on Feb 24, 2021
9. hebasto approved
10. 
    hebasto commented at 8:24 am on February 24, 2021: member

    ACK 5440c074579f5588cdcff3d33bd1350cee0b7bff, verified that 22664d6287dda243ebf06df4409b50ab509603e1 is a clean revert of 8f9644890a167a093d95ecef1f12a20dce1bc581.
11. 
    luke-jr commented at 3:53 pm on February 24, 2021: member

    Concept ACK, thanks
12. 
    MarcoFalke commented at 8:09 am on February 25, 2021: contributor

    (edited OP before merge to remove @)
13. MarcoFalke merged this on Feb 25, 2021
14. MarcoFalke closed this on Feb 25, 2021

    ---

15. sidhujag referenced this in commit ac3ba46626 on Feb 25, 2021
16. PastaPastaPasta referenced this in commit 89e8811f4a on Sep 17, 2021
17. PastaPastaPasta referenced this in commit 36d2dc7251 on Sep 19, 2021
18. thelazier referenced this in commit 7e5ff3cbdd on Sep 25, 2021
19. gwillen referenced this in commit 62c104e117 on Jun 28, 2022
20. bitcoin-core locked this on Aug 16, 2022

Contributors
laanwj sipa hebasto jarolrod luke-jr MarcoFalke