Drop unused parameter in GUIUtil::get{Save|Open}FileName #228

1. 
   hebasto commented at 9:48 pm on February 24, 2021: member
2. qt: Drop unused parameter in GUIUtil::getSaveFileName 9e68dd9982
3. qt: Drop unused parameter in GUIUtil::getOpenFileName c3c9d8db30
4. MarcoFalke added the label Refactoring on Feb 25, 2021
5. 
   jonatack commented at 11:32 am on February 25, 2021: contributor

   Code review ACK c3c9d8db30a4148eeb14db0ac10f0f27fced1087 (but should this feature be used instead?)
6. 
   hebasto commented at 11:43 am on February 25, 2021: member

   @jonatack

   but should this feature be used instead?

   From https://doc.qt.io/qt-5/qfiledialog.html#getOpenFileName and https://doc.qt.io/qt-5/qfiledialog.html#getSaveFileName it follows that the selectedFilter out parameter is useful only in cases when multiple filters are passed to the filter parameter. That is not our case, right?

7. Talkless approved
8. 
   Talkless commented at 6:03 pm on February 25, 2021: none

   utACK c3c9d8db30a4148eeb14db0ac10f0f27fced1087. Haven’t even built, don’t see anything to test.
9. luke-jr changes_requested
10. 
    luke-jr commented at 4:25 pm on February 27, 2021: member

    Concept NACK to removing the option entirely. This looks useful for allowing the user to save a plaintext backup file from the GUI, or a fully signed transaction in normal transaction format…

    Maybe make it default to nullptr and omit in callers that don’t use it, though..

11. 
    hebasto commented at 4:30 pm on February 27, 2021: member

    @luke-jr

    This looks useful for allowing the user to save a plaintext backup file from the GUI…

    Do you mean providing filters like "Binary Wallet Data (*.dat);;Plain Text Wallet Data (*.txt)" ?

12. 
    luke-jr commented at 5:35 pm on February 27, 2021: member

    Yes, see #230 :)
13. 
    hebasto commented at 6:51 pm on February 27, 2021: member

    @jonatack

    but should this feature be used instead? @luke-jr Yes, see #230 :)

    Closing.

14. hebasto closed this on Feb 27, 2021

    ---

15. bitcoin-core locked this on Aug 16, 2022

Contributors
hebasto jonatack Talkless luke-jr

Labels
Refactoring