No description provided.
Drop unused parameter in GUIUtil::get{Save|Open}FileName #228
pull hebasto wants to merge 2 commits into bitcoin-core:master from hebasto:210224-file changing 8 files +12 −39-
hebasto commented at 9:48 PM on February 24, 2021: member
-
qt: Drop unused parameter in GUIUtil::getSaveFileName 9e68dd9982
-
qt: Drop unused parameter in GUIUtil::getOpenFileName c3c9d8db30
- MarcoFalke added the label Refactoring on Feb 25, 2021
-
jonatack commented at 11:32 AM on February 25, 2021: contributor
Code review ACK c3c9d8db30a4148eeb14db0ac10f0f27fced1087 (but should this feature be used instead?)
-
hebasto commented at 11:43 AM on February 25, 2021: member
but should this feature be used instead?
From https://doc.qt.io/qt-5/qfiledialog.html#getOpenFileName and https://doc.qt.io/qt-5/qfiledialog.html#getSaveFileName it follows that the
selectedFilterout parameter is useful only in cases when multiple filters are passed to thefilterparameter. That is not our case, right? - Talkless approved
-
Talkless commented at 6:03 PM on February 25, 2021: none
utACK c3c9d8db30a4148eeb14db0ac10f0f27fced1087. Haven't even built, don't see anything to test.
- luke-jr changes_requested
-
luke-jr commented at 4:25 PM on February 27, 2021: member
Concept NACK to removing the option entirely. This looks useful for allowing the user to save a plaintext backup file from the GUI, or a fully signed transaction in normal transaction format...
Maybe make it default to nullptr and omit in callers that don't use it, though..
-
-
-
- hebasto closed this on Feb 27, 2021
- bitcoin-core locked this on Aug 16, 2022
Labels