Issue with spaces with sentence containing commas and periods. #235

issue edumorlom openend this issue on March 2, 2021
  1. edumorlom commented at 10:00 am on March 2, 2021: none

    I am seeing space issues after periods and commas in the “Welcome to Bitcoin Core” screen. See the screenshot attached.

    Upon looking at the translation files, I don’t see any immediate issues with the strings: https://github.com/bitcoin-core/gui/blob/54fc96ffa70ad3a53d32709101b7a2ce064d822e/src/qt/forms/intro.ui

    I am running macOS Big Sur.

  2. edumorlom commented at 10:02 am on March 2, 2021: none

    Seems to be a global issue, maybe?

  3. hebasto commented at 3:24 pm on March 2, 2021: member

    Tested on Big Sur 11.2.2 (20D80) with a patch that allows select and copy the first paragraph:

     0--- a/src/qt/forms/intro.ui
     1+++ b/src/qt/forms/intro.ui
     2@@ -51,6 +51,9 @@
     3      <property name="wordWrap">
     4       <bool>true</bool>
     5      </property>
     6+     <property name="textInteractionFlags">
     7+      <set>Qt::LinksAccessibleByMouse|Qt::TextSelectableByMouse</set>
     8+     </property>
     9     </widget>
    10    </item>
    11    <item>
    

    Then the selected text pasted into the TextEdit: Screenshot from 2021-03-02 17-19-19

    Text is fine.

    I think that the default macOS font issue is out of our scope.

  4. edumorlom commented at 7:54 pm on March 3, 2021: none
    Should we close the issue? @hebasto
  5. hebasto commented at 7:55 pm on March 3, 2021: member

    Should we close the issue? @hebasto

    Yes, I think.

  6. edumorlom closed this on Mar 3, 2021

  7. hebasto added the label macOS on Mar 5, 2021
  8. bitcoin-core locked this on Aug 16, 2022


edumorlom hebasto

Labels
macOS


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-23 07:20 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me