Make Close/OK buttons consistent across all windows #25

issue statusquont openend this issue on July 2, 2020
  1. statusquont commented at 6:00 pm on July 2, 2020: none

    Here are 4 different application windows with different actions for closing the windows. Sometimes it says ‘Close’, sometimes ‘OK’. All times there is a native OS close option.

    image

    Personally, I think less is more, and you can just get rid of them all together and just let the user use the native OS windowing [X] to close them. Reduce decision fatigue with fewer options to consider and a cleaner UI.

  2. Sjors commented at 6:42 pm on July 2, 2020: member
    Assuming the native close option is available and reasonably visible on all platforms, I tend to agree.
  3. hebasto commented at 8:15 am on July 11, 2020: member

    The presence of the window close button [X] depends on the underlying window manager. There is no guarantee that every window manager supports it. Also it is an extra burden to test the GUI compatibility with a large set of window managers.

    On Android there is no window frame at all.

    So, currently, I lean to NACK.

  4. Sjors commented at 6:25 am on July 17, 2020: member
    Doesn’t Android rely on the physical back button to leave a window?
  5. jarolrod commented at 5:33 am on February 23, 2021: member

    NACK, not all systems will have a WM that provides a native close button. Other systems can be configured not to have the native close button (i3, dwm, etc …). If we removed the ok/cancel buttons, those with the aforementioned systems would not have a way to close a window, except for a keyboard close window shortcut.

    As for the point that sometimes there’s an Ok button and other times, there’s a Close button: This seems ok depending on the context the window is opened with. The receiving addresses and sending addresses windows are opened in the context of ‘performing an action’, so it makes sense that the exit button says close. The Command-line Options window is opened in the context of retrieving information, so, to me, it’s fine that the exit button says Ok. As in, Ok, I’ve found what I needed to find.

  6. hebasto added the label Design on Mar 5, 2021
  7. MarcoFalke referenced this in commit bce09da122 on Apr 28, 2021
  8. MarcoFalke referenced this in commit c857148636 on May 15, 2021
  9. fanquake referenced this in commit 7b45d171f5 on May 2, 2023
  10. fanquake referenced this in commit 8d5b93cf54 on Jun 21, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-23 09:20 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me