scripted-diff: Drop redundant QString calls #250

pull hebasto wants to merge 1 commits into bitcoin-core:master from hebasto:210314-tr changing 1 files +10 −10
  1. hebasto commented at 11:25 pm on March 14, 2021: member
    The return type of QObject::tr function is QString :tiger2:
  2. scripted-diff: Drop redundant QString calls
    -BEGIN VERIFY SCRIPT-
    sed -i 's/QString(QObject::tr(\([^)]*\))/QObject::tr(\1/' src/qt/guiutil.cpp
    -END VERIFY SCRIPT-
    def1e64bb4
  3. hebasto added the label Refactoring on Mar 15, 2021
  4. jarolrod commented at 6:10 am on March 15, 2021: member

    ACK def1e64bb4fc902bfc19d6487b33cd940f0e0f34, tested on macOS 10.14.6 Qt 5.15.2

    This change is correct according to the Qt docs: https://doc.qt.io/qt-5/qobject.html#tr

    Verified that these are all the occurrences of this case. Ran bitcoin-qt and verified there are no alterations of behavior with this change.

  5. MarcoFalke merged this on Mar 15, 2021
  6. MarcoFalke closed this on Mar 15, 2021

  7. sidhujag referenced this in commit 3b3100cb43 on Mar 15, 2021
  8. hebasto deleted the branch on Mar 15, 2021
  9. gwillen referenced this in commit f5f1e8d3d5 on Jun 28, 2022
  10. bitcoin-core locked this on Aug 16, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-23 00:20 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me