refactor: Drop redundant setEditTriggers(NoEditTriggers) calls #254

pull hebasto wants to merge 1 commits into bitcoin-core:master from hebasto:210323-edit changing 1 files +0 −2

hebasto commented at 2:14 PM on March 23, 2021: member

The models of the both views have no Qt::ItemIsEditable flag: https://github.com/bitcoin-core/gui/blob/3c87dbe95c925274f80234ad4a88beb5a05fdfff/src/qt/peertablemodel.cpp#L218-L224 https://github.com/bitcoin-core/gui/blob/3c87dbe95c925274f80234ad4a88beb5a05fdfff/src/qt/bantablemodel.cpp#L148-L154
qt, refactor: Drop redundant setEditTriggers(NoEditTriggers) calls
The models of the both views have no Qt::ItemIsEditable flag.
257f55c119
hebasto added the label Refactoring on Mar 23, 2021
hebasto marked this as a draft on Mar 23, 2021
hebasto marked this as ready for review on Mar 23, 2021
Talkless approved
Talkless commented at 7:01 PM on March 23, 2021: none

utACK 257f55c119c2c63245f3a84a9cd8f7aaeaf2d129, seems reasonable.
jarolrod commented at 2:16 AM on March 26, 2021: member

ACK 257f55c119c2c63245f3a84a9cd8f7aaeaf2d129, looks correct.

Tested for any weird behavior on macOS 11.2.3 Qt 5.15.2
hebasto closed this on Mar 28, 2021
hebasto reopened this on Mar 28, 2021
MarcoFalke merged this on Mar 28, 2021
MarcoFalke closed this on Mar 28, 2021
hebasto deleted the branch on Mar 28, 2021
sidhujag referenced this in commit 64888531f1 on Mar 28, 2021
PastaPastaPasta referenced this in commit 564d7b6e74 on Jun 27, 2021
PastaPastaPasta referenced this in commit f574fe8565 on Jun 28, 2021
PastaPastaPasta referenced this in commit efb73a69f3 on Jun 29, 2021
PastaPastaPasta referenced this in commit ee18eaff1f on Jul 1, 2021
PastaPastaPasta referenced this in commit 26656e833f on Jul 1, 2021
PastaPastaPasta referenced this in commit 6905d1151c on Jul 15, 2021
PastaPastaPasta referenced this in commit 9188e1fa4c on Jul 15, 2021
PastaPastaPasta referenced this in commit a5c84be618 on Jul 16, 2021
gades referenced this in commit 1fbc107b4d on May 9, 2022
gwillen referenced this in commit 79b53bada9 on Jun 1, 2022
bitcoin-core locked this on Aug 16, 2022

Contributors

Labels