refactor: Use template function qOverload in signal-slot connections #257

pull hebasto wants to merge 1 commits into bitcoin-core:master from hebasto:210323-overload changing 9 files +20 −20

hebasto commented at 3:45 am on March 24, 2021: member

A nice template function qOverload is available for us now (https://github.com/bitcoin/bitcoin/pull/20413, https://github.com/bitcoin/bitcoin/pull/21286).

Its usage makes code much more readable.

This PR does not change behavior.
hebasto added the label Refactoring on Mar 24, 2021
hebasto closed this on Mar 24, 2021
hebasto reopened this on Mar 24, 2021
hebasto closed this on Apr 3, 2021
hebasto reopened this on Apr 3, 2021
jarolrod commented at 10:43 pm on April 26, 2021: member

ACK c8169f42a08236ae0c032834ae896faa8db83338

The use of qOverload is correct and is a nice simplication. Tested that behavior remains the same.
hebasto commented at 8:17 pm on April 29, 2021: member

@Talkless

wrt your comment:

IIRC qOverload function template does not work with Visual Studio 2017 due to implementation limitations…

have you any update?
qt: Use template function qOverload in signal-slot connections
This commit does not change behavior.
cdbc2bd1f1
hebasto force-pushed on Apr 29, 2021
hebasto commented at 9:01 pm on April 29, 2021: member

Rebased c8169f42a08236ae0c032834ae896faa8db83338 -> cdbc2bd1f1c171848c1fef7f217afe140e1afb06 (pr257.01 -> pr257.02) due to the conflict with #125.
hebasto commented at 6:59 am on May 2, 2021: member

@Talkless

IIRC qOverload function template does not work with Visual Studio 2017 due to implementation limitations…

That is not the case now since https://github.com/bitcoin/bitcoin/pull/21811 is merged.
Talkless approved
Talkless commented at 6:05 pm on May 6, 2021: none

utACK cdbc2bd1f1c171848c1fef7f217afe140e1afb06.

I did build on Debian Sid and Debian 10 Buster but did not check any signals in running program. All changes looks clear. Nice upgrade.
hebasto requested review from promag on May 8, 2021
promag commented at 6:11 pm on May 10, 2021: contributor

Code review ACK cdbc2bd1f1c171848c1fef7f217afe140e1afb06.

Thanks for also updating QOverload<T>::of in intro.cpp.
hebasto merged this on May 10, 2021
hebasto closed this on May 10, 2021
hebasto deleted the branch on May 10, 2021
sidhujag referenced this in commit 5ab484ceb8 on May 11, 2021
gwillen referenced this in commit e8208438a1 on Jun 1, 2022
bitcoin-core locked this on Aug 16, 2022

Contributors
hebasto jarolrod Talkless promag

Labels
Refactoring