When opening or autoloading wallets there should be clear messages about rescanning in progress and wallets’ names. #259

1. 
   streamofstars commented at 12:53 pm on March 26, 2021: none

   There are at least two ways to open a wallet.

   1. File, Open wallet
   2. or by manually appending settings.json file with wallet name.

   When opening a wallet that has not been synchronized recently, in the first case there is a small window displayed with a message “opening wallet ”. The node is rescanning at this time but nothing really indicates that, so unless user peeks in the debug.log file they may think bitcoin core is stuck.

   In the second scenario, the initial window displays a message with just a single word “rescanning”. This is better in a way that at least, as a user I am not confused about what is actually happening. However, there is a different problem: no indication about which wallet is being loaded. If a user has multiple wallets and don’t keep them all opened all the time, but opens one, closes another and so on, upon (re)starting Bitcoin-qt they would not know for which wallet rescanning is happening.

   In my opinion, both windows should clearly state:

   • what is going on right now exactly, i.e. rescanning
   • names of wallets that are being loaded
2. hebasto added the label Feature on Mar 26, 2021
3. hebasto added the label good first issue on Mar 31, 2021
4. 
   hebasto commented at 6:06 pm on March 31, 2021: member

   Adding a named wallet to the string presented to the user should be a one-line change.

   FIX: Explicitly enumerate all cases and be sure to not add the wallet name in one window and not leave others unnamed. E.g., “Sending/Receiveing addresses” windows.

   Additionally, adding a comment to mention when not naming is required would be appreciated.

5. 
   streamofstars commented at 8:05 pm on March 31, 2021: none

   Keep in mind that there is also a case to cover in my second scenario where a json file is configured to load multiple wallets and more than one require rescanning. However, I am not familiar with how the rescan feature works under the hood specifically. Whether it rescans for each wallet one by one or rescans for all loaded wallets at once. If the latter is the case, is it really feasible to list all those wallets there? Two or three is fine but what if someone has dozens of them? (unless there is a limit to the number of wallets)
6. 
   hebasto commented at 8:09 pm on March 31, 2021: member

   Whether it rescans for each wallet one by one or rescans for all loaded wallets at once

   IIRC, the former one.

7. hebasto removed the label Feature on May 1, 2021
8. hebasto added the label UX on May 1, 2021
9. 
   hebasto commented at 4:49 pm on November 6, 2021: member

   @khan201kp

   What do you mean by wallet name?

   A Wallet::getWalletName() return value: https://github.com/bitcoin-core/gui/blob/77a2f5d30c5ecb764b8a7c098492e1f5cdec90f0/src/interfaces/wallet.h#L82-L83

10. 
    AdarshRawat1 commented at 9:14 am on March 17, 2023: none

    can I work on this issue?
11. 
    hebasto commented at 10:55 am on March 17, 2023: member

    @AdarshRawat1

    can I work on this issue?

    This project is permissionless.

    Feel free to open a PR :)

12. xonx4l referenced this in commit 3573708656 on Jan 10, 2024

Contributors
streamofstars hebasto AdarshRawat1

Labels
good first issue UX