macOS theme switching not supported #268

pull jarolrod wants to merge 1 commits into bitcoin-core:master from jarolrod:doc-switch-macos changing 1 files +1 −0
  1. jarolrod commented at 5:30 am on April 3, 2021: member

    It was originally believed that theme switching on macOS was broken only on macOS 10.14: #154 (comment), #154#pullrequestreview-600078428

    It is actually broken on Catalina and Big Sur as well (building and compiling off master). When switching from one theme to another the Icons do not get re-colorized.

    This PR documents that theme switching is not currently supported in the release notes. Based on #154 (comment), but drops the macOS 10.14 part.

    Below are screenshots that were taken on Big Sur which show this behavior. The same occurs on Catalina.

    Light Mode to Dark Mode

    Light Mode Dark Mode
    Screen Shot 2021-04-02 at 3 39 05 PM Screen Shot 2021-04-02 at 3 39 32 PM

    Dark Mode to Light Mode

    Dark Mode Light Mode
    Screen Shot 2021-04-02 at 3 40 22 PM Screen Shot 2021-04-02 at 3 40 31 PM
  2. doc: macOS theme switching not supported
    Document that theme switching on macOS, switching between light and dark mode, is currently broken.
    6b586ffdc8
  3. hebasto added the label Doc on Apr 3, 2021
  4. hebasto commented at 6:42 am on April 9, 2021: member
    Hoping #275 will make this change unnecessary :)
  5. hebasto added the label macOS on Apr 9, 2021
  6. hebasto commented at 9:51 pm on May 10, 2021: member

    @jarolrod

    Is this really needed now?

  7. jarolrod commented at 9:56 pm on May 10, 2021: member
    @hebasto It won’t be needed so long as we can get #275 in before the freeze. Otherwise, it is needed.
  8. hebasto referenced this in commit 123b401e0a on May 28, 2021
  9. jarolrod commented at 4:06 pm on May 28, 2021: member
    Closing since #275 was merged 🎉
  10. jarolrod closed this on May 28, 2021

  11. bitcoin-core locked this on Aug 16, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-23 00:20 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me