Move the UI window style to a top to bottom layout #27

pull Saibato wants to merge 2 commits into bitcoin-core:master from Saibato:move-ui-to-mobile changing 2 files +330 −375

Saibato commented at 7:59 AM on July 3, 2020: contributor

This is part of {wip} side project i had to make the ui more user friendly when run on mobile i.e in termux or other linux mobile environtments that can show our qt ui.

Move the debug window style to a top to bottom layout

When we want to run the UI on mobile a top
to bottom style is key.

Signed-off-by: saibato <saibato.naga@pm.me>

b3939e1efb

Saibato commented at 8:03 AM on July 3, 2020: contributor
Saibato renamed this:
~~Move the debug window style to a top to bottom layout~~
Move the UI window style to a top to bottom layout
on Jul 3, 2020
Move the overviewpage to top to bottom style
Signed-off-by: saibato <saibato.naga@pm.me>
0d80be7701
Saibato commented at 8:30 AM on July 3, 2020: contributor
luke-jr commented at 9:01 PM on July 31, 2020: member

This seems very undesirable on desktops... Shouldn't it be an option, or at least based on screen ratio?
Saibato commented at 8:03 AM on August 1, 2020: contributor

I fiddled around with long v3 Tor and i2p addresses and they where truncated way to much and even on desktop, i guess that could make sense to have this layout for ppl, to cherrypick on top of there compile of core if testing v3 or other things when you want multiple nodes side by side.

And since it make no sense to use the pre-builds, your are right, its an option, for sovereign multiplatform coiners.

be an option, or at least based on screen ratio?

i.e../configure --gui-top-bottom-design ?
luke-jr commented at 8:08 AM on August 1, 2020: member

I was thinking a checkbox in the GUI settings at runtime.
Saibato commented at 8:59 AM on August 1, 2020: contributor

I was thinking a checkbox in the GUI settings at runtime.

even better, but since the ui is fixed and the headers are created at compile time. I am not quite sure how to do that? Two layouts ? ping @hebasto
hebasto commented at 10:59 AM on August 1, 2020: member

I was thinking a checkbox in the GUI settings at runtime.

even better, but since the ui is fixed and the headers are created at compile time. I am not quite sure how to do that? Two layouts ? ping @hebasto

Probably building layouts dynamically rather using *.ui forms is a way, no?
luke-jr commented at 3:39 PM on August 1, 2020: member

Or modifying the default layout in code should also be possible.
RandyMcMillan commented at 10:24 PM on September 14, 2020: contributor

I believe that the over all interface should maintain a "Landscape" layout - This approach seems to be forcing a "Portrait" layout...which isn't optimal.

Either way - optimizing the use of the empty space may guide layout decisions...

For example:

Notice how much empty space can be utilized in other ways...

By formatting the layout of the text - this extra space can be used by the peer detail widget...

Some simple changes could be in the NodeID column - this could be simplified to ID I don't think sorting by NodeID is particularly useful and could be disabled for better display of the label.

Also removing the slashes from the User Agent display would look better..
jarolrod commented at 4:53 PM on December 4, 2020: member

Concept ACK on reordering widgets on overviewpage.ui. NACK on reordering widgets under debugwindow.ui. This leads to a lot of wasted space under the peers tab (shown below).
jonasschnelli commented at 8:13 AM on December 7, 2020: contributor

The layout should depend on the screensize ratio (or on the window-size ratio). I agree that Core should also have an option to run on rather portrait mode screens and devices.

Ideally, the design-implementation can handle run-time window size changes and switches from landscape to top-down mode. Similar to how webpages have a floating design.

If too complicated, I agree with @luke-jr about the checkbox-in-settings approach. A compile option seems not ideal to me.
MarcoFalke referenced this in commit c857148636 on May 15, 2021
rebroad commented at 11:06 AM on August 25, 2021: contributor

Agree with @luke-jr - this should not be hardcoded but instead based on screen ratio - or better still, user-overridable. So NACK for now.
hebasto commented at 6:46 PM on September 7, 2021: member

The flowing GUI could be implemented in https://github.com/bitcoin-core/gui-qml/blob/main/src/qml/README.md

Closing this for now.
hebasto closed this on Sep 7, 2021
bitcoin-core locked this on Sep 7, 2022