[PoC] [do not merge]: Support runtime appearance adjustment on macOS #274

pull hebasto wants to merge 2 commits into bitcoin-core:master from hebasto:210407-dark-poc changing 3 files +27 −17
  1. hebasto commented at 7:13 am on April 7, 2021: member
    Only toolbar icons support Dark/Light runtime switching for now.
  2. qt: Make PlatformStyle aware of runtime palette change 
    This change is a prerequisite to support changeable appearance on macOS.
    110a58ef22
  3. qt: Make BitcoinGUI aware of runtime palette change 
    This change fixes the GUI when changing appearance on macOS.
    0993439ce0
  4. hebasto added the label macOS on Apr 7, 2021
  5. jarolrod commented at 2:59 pm on April 8, 2021: member

    Concept ACK,

    This seems to be a step in the right direction to supporting theme switching on macOS. The icons this PR touches do get recolorized.

    Below are some screenshots with all possible build options on macOS 11.2.3 and macOS 10.15.7, comparing master and pr.

    It is weird that dark mode does not work at all on a native depends build, but works on a cross-compile depends build.

    Master

    Compiled Natively

    macOS 11.2.3

    Start: Light Mode Switch to Dark Mode
    Screen Shot 2021-04-07 at 12 27 07 PM Screen Shot 2021-04-07 at 12 27 27 PM

    macOS 10.15.7

    Start: Light Mode Switch to Dark Mode

    Depends Build Natively

    macOS 11.2.3

    Start: Light Mode Switch to Dark Mode
    Screen Shot 2021-04-07 at 1 33 10 PM Screen Shot 2021-04-07 at 1 33 19 PM

    macOS 10.15.7

    Start: Light Mode Switch to Dark Mode

    Depends Cross Compile (from Linux)

    macOS 11.2.3

    Start: Light Mode Switch to Dark Mode
    before after

    macOS 10.15.7

    Start: Light Mode Switch to Dark Mode
    Screen Shot 2021-04-07 at 9 16 29 PM Screen Shot 2021-04-07 at 9 16 47 PM

    PR 0993439ce0840a68e189add369ea8e9f92b5c2c4

    Compiled Natively

    macOS 11.2.3

    Start: Light Mode Switch to Dark Mode
    Screen Shot 2021-04-07 at 12 06 55 PM Screen Shot 2021-04-07 at 12 10 11 PM

    macOS 10.15.7

    Start: Light Mode Switch to Dark Mode

    Depends Build Natively

    macOS 11.2.3

    Start: Light Mode Switch to Dark Mode
    before after

    macOS 10.15.7

    Start: Light Mode Switch to Dark Mode

    Depends Cross Compile (from Linux)

    macOS 11.2.3

    Start: Light Mode Switch to Dark Mode
    Screen Shot 2021-04-07 at 9 53 39 PM Screen Shot 2021-04-07 at 9 54 00 PM

    macOS 10.15.7

    Start: Light Mode Switch to Dark Mode
  6. hebasto commented at 6:36 am on April 9, 2021: member
    Closed in favor of the complete solution #275.
  7. hebasto closed this on Apr 9, 2021
  8. hebasto deleted the branch on Apr 9, 2021
  9. bitcoin-core locked this on Aug 16, 2022


hebasto jarolrod

Labels
macOS

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-23 00:20 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me