[PoC] [do not merge]: Support runtime appearance adjustment on macOS #274

hebasto commented at 7:13 AM on April 7, 2021: member

Only toolbar icons support Dark/Light runtime switching for now.

qt: Make PlatformStyle aware of runtime palette change

This change is a prerequisite to support changeable appearance on macOS.

110a58ef22

qt: Make BitcoinGUI aware of runtime palette change

This change fixes the GUI when changing appearance on macOS.

0993439ce0

hebasto added the label macOS on Apr 7, 2021

jarolrod commented at 2:59 PM on April 8, 2021: member

Concept ACK,

This seems to be a step in the right direction to supporting theme switching on macOS. The icons this PR touches do get recolorized.

Below are some screenshots with all possible build options on macOS 11.2.3 and macOS 10.15.7, comparing master and pr.

It is weird that dark mode does not work at all on a native depends build, but works on a cross-compile depends build.

Master

Compiled Natively

macOS 11.2.3

Start: Light Mode	Switch to Dark Mode

macOS 10.15.7

Start: Light Mode	Switch to Dark Mode
<img width="891" alt="before" src="https://user-images.githubusercontent.com/23396902/114047150-748e6d80-9857-11eb-9d70-9f73586adf1b.png">	<img width="891" alt="after" src="https://user-images.githubusercontent.com/23396902/114047213-8112c600-9857-11eb-8e4d-683005a0f3e3.png">

Depends Build Natively

macOS 11.2.3

Start: Light Mode	Switch to Dark Mode

macOS 10.15.7

Start: Light Mode	Switch to Dark Mode
<img width="891" alt="before" src="https://user-images.githubusercontent.com/23396902/114047773-f1b9e280-9857-11eb-9430-4a409c7e6825.png">	<img width="891" alt="after" src="https://user-images.githubusercontent.com/23396902/114047825-fc747780-9857-11eb-821b-4c70acaba9d0.png">

Depends Cross Compile (from Linux)

macOS 11.2.3

Start: Light Mode	Switch to Dark Mode

macOS 10.15.7

Start: Light Mode	Switch to Dark Mode

PR 0993439ce0840a68e189add369ea8e9f92b5c2c4

Compiled Natively

macOS 11.2.3

Start: Light Mode	Switch to Dark Mode

macOS 10.15.7

Start: Light Mode	Switch to Dark Mode
<img width="891" alt="Screen Shot 2021-04-07 at 5 57 09 PM" src="https://user-images.githubusercontent.com/23396902/114048396-86bcdb80-9858-11eb-8d85-608534d2c626.png">	<img width="891" alt="Screen Shot 2021-04-07 at 5 57 25 PM" src="https://user-images.githubusercontent.com/23396902/114048413-8b818f80-9858-11eb-9d92-ff6628a2644e.png">

Depends Build Natively

macOS 11.2.3

Start: Light Mode	Switch to Dark Mode

macOS 10.15.7

Start: Light Mode	Switch to Dark Mode
<img width="891" alt="before" src="https://user-images.githubusercontent.com/23396902/114048813-e4512800-9858-11eb-80ac-ebe670bdbfb5.png">	<img width="891" alt="after" src="https://user-images.githubusercontent.com/23396902/114048842-e87d4580-9858-11eb-867a-360de0d72626.png">

Depends Cross Compile (from Linux)

macOS 11.2.3

Start: Light Mode	Switch to Dark Mode

macOS 10.15.7

Start: Light Mode	Switch to Dark Mode
<img width="891" alt="before" src="https://user-images.githubusercontent.com/23396902/114049082-22e6e280-9859-11eb-9fc0-0150f726a006.png">	<img width="891" alt="Screen Shot 2021-04-07 at 6 59 56 PM" src="https://user-images.githubusercontent.com/23396902/114049106-27130000-9859-11eb-89e1-c0a5e3fb3628.png">

hebasto commented at 6:36 AM on April 9, 2021: member

Closed in favor of the complete solution #275.

hebasto closed this on Apr 9, 2021

hebasto deleted the branch on Apr 9, 2021

bitcoin-core locked this on Aug 16, 2022