Elide long strings in their middle in the Peers tab #276

1. 
   hebasto commented at 11:15 am on April 10, 2021: member

   The eliding of long addresses (Onion v3 etc) in the Peers tab in their middle was discussed in #262.

   On master (f0fa32450ec35056b3e1025262aeaef4a24c35ee):

   With this PR:

   This PR suggests the minimal diff to achieve the goal. OTOH, this change in behavior is common for all columns in the Peers table, but it seems harmless.

2. qt: Elide long strings in their middle in the Peers tab 4e0613369f
3. hebasto added the label Feature on Apr 10, 2021
4. hebasto added the label Design on Apr 10, 2021
5. 
   jonatack commented at 11:45 am on April 10, 2021: contributor

   Concept ACK, this looks like a real and practical improvement.
6. 
   promag commented at 7:01 pm on April 10, 2021: contributor

   Concept ACK

   Why does it only show ellipsis on the 1st screenshot?

7. 
   hebasto commented at 7:36 pm on April 10, 2021: member

   Because of wordWrap=true by default.

   On Sat, 10 Apr 2021 at 22:01 João Barbosa @.***> wrote:

   @.**** commented on this pull request.

   Concept ACK

   Why does it show only ellipsis on the 1st sreenshot?

   — You are receiving this because you authored the thread.

   Reply to this email directly, view it on GitHub https://github.com/bitcoin-core/gui/pull/276#pullrequestreview-632945368, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH3PXPSYOICYOCDSTHGZVMDTICOARANCNFSM42WM3Z6A .

   –

   – Hennadii Stepanov

8. 
   jarolrod commented at 9:51 pm on April 11, 2021: member

   tACK 4e0613369f446b0a57783bf9e7258fec6c474981

   tested on macOS 11.2.3 Qt 5.15.2

   

9. 
   promag commented at 8:16 am on April 19, 2021: contributor

   Code review ACK 4e0613369f446b0a57783bf9e7258fec6c474981.

   Unfortunately, Qt doesn’t support setting elide mode per column. This PR changes elide mode for all columns but along with minimum columns, it’s actually a nice change.

10. hebasto merged this on Apr 19, 2021
11. hebasto closed this on Apr 19, 2021

    ---

12. 
    promag commented at 10:13 am on April 19, 2021: contributor

    🎉
13. sidhujag referenced this in commit 3b2479c022 on Apr 19, 2021
14. hebasto deleted the branch on Apr 20, 2021
15. barton2526 referenced this in commit 0c69fb8455 on Jul 17, 2021
16. barton2526 referenced this in commit f50640b30f on Jul 17, 2021
17. PastaPastaPasta referenced this in commit 86c19334ec on Oct 20, 2021
18. PastaPastaPasta referenced this in commit f8802b4a5d on Oct 21, 2021
19. pravblockc referenced this in commit 90c6e996f1 on Nov 18, 2021
20. gades referenced this in commit ac3b2a7244 on May 9, 2022
21. gwillen referenced this in commit 73880cb3b2 on Jun 1, 2022
22. bitcoin-core locked this on Aug 16, 2022

Contributors
hebasto jonatack promag jarolrod

Labels
Feature Design