The eliding of long addresses (Onion v3 etc) in the Peers tab in their middle was discussed in #262.
On master (f0fa32450ec35056b3e1025262aeaef4a24c35ee):
With this PR:
This PR suggests the minimal diff to achieve the goal. OTOH, this change in behavior is common for all columns in the Peers table, but it seems harmless.
Concept ACK, this looks like a real and practical improvement.
Concept ACK
Why does it only show ellipsis on the 1st screenshot?
Because of wordWrap=true by default.
On Sat, 10 Apr 2021 at 22:01 João Barbosa @.***> wrote:
@.**** commented on this pull request.
Concept ACK
Why does it show only ellipsis on the 1st sreenshot?
— You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/bitcoin-core/gui/pull/276#pullrequestreview-632945368, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH3PXPSYOICYOCDSTHGZVMDTICOARANCNFSM42WM3Z6A .
--
-- Hennadii Stepanov
tACK 4e0613369f446b0a57783bf9e7258fec6c474981
tested on macOS 11.2.3 Qt 5.15.2
Code review ACK 4e0613369f446b0a57783bf9e7258fec6c474981.
Unfortunately, Qt doesn't support setting elide mode per column. This PR changes elide mode for all columns but along with minimum columns, it's actually a nice change.
🎉