Peer id improvements
#290
This patch:
renames the peers tab column header from Peer Id to Peer to allow resizing the column more tightly (this will be particularly useful after #256) and does the same for the peer details area.
center-aligns the entries in the Peer column to align them under the column header rather than to the left (I also tried right-alignment but the values are unreadably close to the Address values and it seems more esthetic to be aligned under the header :file_cabinet:)
to allow resizing the column more tightly
This aligns them under the column header.
Tested on MacOS 10.14.6 (18G103)
renaming to Id instead of Peer would work also but I’m not sure about translateability
What are the concerns exactly?
renaming to
Idinstead ofPeerwould work also but I’m not sure about translateability
“Id” seems to be a short for “Identifier” in most of the languages I checked. Are there exceptions for that and languages where “Id” can’t be translated to something similar? https://en.wikipedia.org/wiki/ID
178@@ -179,9 +179,9 @@ QVariant PeerTableModel::data(const QModelIndex &index, int role) const
179 assert(false);
180 } else if (role == Qt::TextAlignmentRole) {
181 switch (column) {
182- case NetNodeId:
183 case Address:
184 return {};
185+ case NetNodeId:
In e14d79f11eaf208b81fc90216304e1e0ea3d673e
Why move the position of NetNodeId here? In the other areas of the code, NetNodeId always comes before Address in our switch statements. I don’t think we should move it here.
You can keep it where it originally is and do:
0 case NetNodeId:
1 return QVariant(Qt::AlignCenter);
AlignCenter. I’d prefer we keep the same order as our other switch statements, but it’s not a strong opinion.
switch statement could decrease mental burden for some ppl :)
ACK e14d79f11eaf208b81fc90216304e1e0ea3d673e
% nit about switch statement order
renaming to Id instead of Peer would work also but I’m not sure about translateability
btw, a good translation of a noun “peer” that means “a participant of the peer-to-peer network” could be a real challenge, at least in some languages :smiley:
Is there a way to tell translators synonyms? “Connection” might be easier to translate.
Yes, could mention synonyms like “connection, number” in the translator comment.
Is there a way to tell translators synonyms? “Connection” might be easier to translate.
Yes, could mention synonyms like “connection, number” in the translator comment.
We could mention the meaning of a term :)
Heh, interesting. Should I mention “ID” in a translation comment? (I’m not against using “ID” instead if reviewers prefer but to my mind it reminds me of “papers, please” police_officer)
If we concern brevity, that the “Peer” word is redundant because the tab is called “Peers”.
If we concern consistency, the getpeerinfo output has the id field.
Anyway, translator comments are always welcome.
IIRC, there were some comments about aligning of the “Peer Id” column in this repo, especially when numbers of id go up. But I cannot find them :(
Maybe our fellow designers @Bosch-0 and @GBKS could share their opinions about this PR?
-netinfo also uses “id”, but ISTM the command line / JSON-RPC interface follows a different paradigm than the GUI:
As for data alignment in the column, note that I discussed what I tried and found in the PR description.
It looks like “peers” and “peer” are already translated in qt/locale (if I understand them correctly) in a number of places; here are just a few of them:
0 <message>
1 <source>&Peers</source>
2 <translation>&Gegenstellen</translation>
3 </message>
4 <message>
5 <source>Banned peers</source>
6 <translation>Gesperrte Gegenstellen</translation>
7 </message>
8 <message>
9 <source>Select a peer to view detailed information.</source>
10 <translation>Gegenstelle auswählen, um detaillierte Informationen zu erhalten.</translation>
11 </message>
0 <message>
1 <source>&Peers</source>
2 <translation>&Пиры</translation>
3 </message>
4 <message>
5 <source>Banned peers</source>
6 <translation>Заблокированные пиры</translation>
7 </message>
8 <message>
9 <source>Select a peer to view detailed information.</source>
10 <translation>Выберите пира для просмотра детальной информации.</translation>
11 </message>
Maybe our fellow designers @Bosch-0 and @GBKS could share their opinions about this PR?
One thought: designer, UI, and UX can be different specialties, a bit like front end / back end / dev ops / DBA / pentest / embedded, etc. There are designers (say, of icons, logos, typography or illustrations) who wouldn’t expect to be asked to make a call about a UI question, and others who might be more comfortable with that.