WIP: translate strings (#288) #292

1. 
   RandyMcMillan commented at 9:31 pm on April 24, 2021: contributor

   Some guidance on this would be appreciated until I get comfortable with this.
2. 
   jonatack commented at 9:43 pm on April 24, 2021: contributor

   The PR description in #287 looks like helpful guidance for this.

   (PS - don’t put @-prefixed usernames in commits and PR descriptions; the latter because usernames in the description are copied into the merge commit by the merge script. This can cause endless annoying notifications for those concerned. An update to the merge script now warns maintainers if a merge message contains a @username, but it’s better not to add them to begin with. For more, see https://jonatack.github.io/articles/how-to-contribute-pull-requests-to-bitcoin-core#pr-descriptions.)

3. RandyMcMillan marked this as a draft on Apr 24, 2021
4. 
   hebasto commented at 12:50 pm on April 25, 2021: member

   @RandyMcMillan

   Thanks for working on this!

   The PR description in #287 looks like helpful guidance for this.

   Indeed, for cases in this PR the translator comments should be used.

   To ensure, that they are working properly, you could use make -C src translate.

   Also for such changes I’d prefer a pr with a wide scope :)

5. hebasto added the label Translations on Apr 25, 2021
6. 
   hebasto commented at 12:55 pm on April 25, 2021: member

   @RandyMcMillan

   If your goal is resolving #288, you could look into #220 where some disambiguation strings were introduced, and they should be replaced with translator comments.

7. guiutil.cpp: add tr stubs for dev notes 16e0df402e
8. askpassphrasedialog.cpp: add tr stubs for dev notes 2027828bae
9. addressbookpage.cpp: add tr stubs for dev notes 5bedecbab4
10. addresstablemodel.cpp: add tr stubs ofr dev notes 7cd4ec506d
11. bantablemodel.cpp: add tr stubs for dev notes 530b1a6712
12. src/qt/bitcoin.cpp: add tr stubs for dev notes 8ee9bf7e5d
13. src/qt/bitcoingui.cpp: add tr stubs for dev notes 3d9c5fa336
14. in src/qt/guiutil.cpp:713 in 2027828bae outdated

    709@@ -710,7 +710,7 @@ QString formatServicesStr(quint64 mask)
    710     if (strList.size())
    711         return strList.join(" & ");
    712     else
    713-        return QObject::tr("None");
    714+        return QObject::tr("None", "absence of value");
    

    ---

    ---

    

    hebasto commented at 8:23 pm on April 25, 2021:

    Our goal is to replace useless (in most cases) disambiguation strings (the second argument in tr call) with translator comments:

    0        //: Absence of value.
    1        return QObject::tr("None");
    

15. 
    RandyMcMillan commented at 9:12 pm on April 25, 2021: contributor

    NOTE: Currently I am just trying to get an idea of how much work needs to be done.
16. 
    hebasto commented at 11:17 am on May 27, 2021: member

    In its current state this PR does not follow our the most recent translation policy, as we are not using the second argument of the QObject:tr function.

    #311 is a good example of the mentioned approach.

    Closing for now.

17. hebasto closed this on May 27, 2021

    ---

18. bitcoin-core locked this on Aug 16, 2022

Contributors
RandyMcMillan jonatack hebasto

Labels
Translations