Avoid unnecessary translations #297

pull hebasto wants to merge 1 commits into bitcoin-core:master from hebasto:210425-btc changing 1 files +4 −4
  1. hebasto commented at 7:01 pm on April 25, 2021: member
    Working on translation, I found these translations introduced in #79, that are unnecessary (assuming the universal nature of the “BTC” string).
  2. qt: Avoid unnecessary translations 19d51a2907
  3. hebasto added the label Translations on Apr 25, 2021
  4. jarolrod commented at 8:37 pm on April 25, 2021: member

    ACK 19d51a2907cc00244510460a658c482d1b4bdfda

    Tested that these are all the occurrences in this file, and cross-checked for any occurrences in other files. We already set the notr attribute in other areas of the code such as coincontroldialog.ui, overviewpage.ui, and sendcoinsdialog.ui.

    Furthermore, BTC is treated as a symbol or unit of Bitcoin and is untranslatable by nature.

  5. Sjors commented at 10:17 am on April 29, 2021: member
    Concept ACK
  6. hebasto requested review from laanwj on May 8, 2021
  7. promag commented at 11:46 pm on May 24, 2021: contributor
    ACK.
  8. hebasto merged this on May 25, 2021
  9. hebasto closed this on May 25, 2021

  10. hebasto deleted the branch on May 25, 2021
  11. sidhujag referenced this in commit 264fad0b67 on May 27, 2021
  12. luke-jr commented at 8:22 pm on June 12, 2021: member
    Is it really untranslated? What about languages that don’t use the Latin alphabet at all?
  13. hebasto commented at 8:29 pm on June 12, 2021: member

    Is it really untranslated? What about languages that don’t use the Latin alphabet at all?

    For example? (not non-Latin languages, but abbreviated name “BTC” in non-Latin languages)

    My three non-Latin languages use “BTC”, btw.

  14. luke-jr commented at 8:53 pm on June 12, 2021: member
    I would expect Russian to use a Cyrillic abbreviation? Possibly Chinese and Japanese to get single-character units at some point?
  15. hebasto commented at 9:01 pm on June 12, 2021: member

    I would expect Russian to use a Cyrillic abbreviation? Possibly Chinese and Japanese to get single-character units at some point?

    I’ve made a quick re-check of some multi-language online services. All of them use “BTC” in non-Latin languages.

  16. gwillen referenced this in commit 9933b7dae8 on Jun 1, 2022
  17. bitcoin-core locked this on Aug 16, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-23 07:20 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me