Peertableview alternating row colors

RandyMcMillan commented at 11:09 pm on April 25, 2021: contributor

peers-tab: enable alternating row colors for peer table and banned table

in src/qt/forms/debugwindow.ui:928 in 0784821425 outdated

924@@ -925,6 +925,9 @@
925              </property>
926              <property name="textElideMode">
927               <enum>Qt::ElideMiddle</enum>
928+              </property>

jarolrod commented at 5:34 pm on April 26, 2021:

You’re introducing this property within the textElideMode property.

You should be introducing this after line 928 on the original file, not after line 927. That way you don’t have to introduce this closing tag to then introduce the property.

Also, the indentation is off here.

RandyMcMillan commented at 11:05 pm on April 26, 2021:

Just trying to edit .ui files without qt-creator - the diff junk qt-creator makes is annoying.

hebasto commented at 6:46 pm on April 29, 2021:

I’m using Qt Designer to edit UI files.

Yeah, in most cases diff junk is unavoidable, but it is easy for me to revert it in Sublime Merge :)

jarolrod commented at 5:38 pm on April 26, 2021: member

Concept ACK

The other table views such as in the Receive and Transactions tab use alternating row colors. Seems appropriate that we also enable this on the Peers table.

qt: peertableview alternating row colors e94920a0bb

RandyMcMillan commented at 11:32 pm on April 26, 2021: contributor

e94920a0bb859d557dd978febde0a65d46fabb68

Screen Shot 2021-04-26 at 7 31 35 PM (2)

jarolrod commented at 2:40 am on April 27, 2021: member

tACK e94920a0bb859d557dd978febde0a65d46fabb68

Can you edit your PR description to include a sentence(s) explaining this change? Normally we don’t leave a PR description empty or only fill it with images. Additionally, edit the PR title to remove the leading qt:. This is redundant as it’s known this is in the GUI repo and the commit title already includes this.

Thanks for also adding this to the Banned Peers table Screen Shot 2021-04-26 at 10 36 06 PM

hebasto added the label Design on Apr 28, 2021

hebasto commented at 1:47 pm on April 28, 2021: member

@Bosch-0, @GBKS

Do you mind having a look into this PR as designers?

jonatack commented at 2:10 pm on April 28, 2021: contributor

I really appreciate @RandyMcMillan’s initiatives to improve the GUI and want to encourage them. In this case, it’s maybe a case of “just because we can may not mean that we should”: (a) separating info for a single peer not only isn’t as critical as it might be for a transaction, but the peers detail area already exists for this, (b) the peers table columns can be as useful (or more useful) information as the the rows (in the peers table, I tend to read the columns) and adding horizontal lines would make that more difficult, and (c) it’s more cluttered and less minimal a design without a real need AFAICT.

RandyMcMillan commented at 4:14 pm on April 28, 2021: contributor

I think this subtle change is useful - alt row colors is a common attribute to many UIs - and I would agree - striking the right balance is critical.

UI-Patterns - AlternatingRowColors

Screen Shot 2021-04-28 at 12 07 36 PM

Screen Shot 2021-04-28 at 12 12 50 PM

This gif offers many variations on table organization:

It is an easy change that helps organize textual information especially as the table gets larger.

Bosch-0 commented at 11:54 pm on April 28, 2021: none

tACK https://github.com/bitcoin-core/gui/commit/e94920a0bb859d557dd978febde0a65d46fabb68 on Windows 10 - works as intended. Before / after below:

Frame 43

I would agree that this is a slight UI/UX improvement though I understand Jon’s concerns. The peers tab isn’t something I’ve used too often so I can not attest to the value of reading info horizontally or vertically, but horizontal alternating row colors is a pretty common design for tables that people will be familiar with and it makes things less visually cluttered.

hebasto renamed this:
~~qt: peertableview alternating row colors~~
Peertableview alternating row colors
on Apr 30, 2021

hebasto merged this on Apr 30, 2021

hebasto closed this on Apr 30, 2021

jonatack commented at 8:23 pm on April 30, 2021: contributor

I think this change makes this window needlessly noisy, more cluttered, and more difficult to use. It was the main tab I used. Oh well.

RandyMcMillan commented at 1:07 am on May 1, 2021: contributor

@jonatack - Maybe we can add more gui options to the user preferences - This may be a great direction to go. I like @hebasto’s addition of the monospace font option - I have plenty of ideas for accessibility that would be great to be able to toggle on/off.

sidhujag referenced this in commit d9c6eb04a2 on May 1, 2021

rebroad commented at 8:25 am on May 1, 2021: contributor

Please can this change be reverted? I agree with @jonatack - there’s way too much info in the right pane now, and I don’t see the need for the alternating colours - I never had an issue following the lines - did anyone else?

Maybe re-merge this in the future once it’s made possible to select which features people want?

rebroad commented at 8:31 am on May 1, 2021: contributor

tACK e94920a on Windows 10 - works as intended. Before / after below:

I would agree that this is a slight UI/UX improvement though I understand Jon’s concerns. The peers tab isn’t something I’ve used too often so I can not attest to the value of reading info horizontally or vertically, but horizontal alternating row colors is a pretty common design for tables that people will be familiar with and it makes things less visually cluttered.

Hold on a moment.. Those two screenshots aren’t a comparison of before and after just this change, are they? Looks like many changes between those two examples…

promag commented at 9:31 pm on May 2, 2021: contributor

ACK, this makes table presentation consistent.

PastaPastaPasta referenced this in commit 811ca70f4b on Oct 20, 2021

PastaPastaPasta referenced this in commit def4afe732 on Oct 21, 2021

pravblockc referenced this in commit e488115ef5 on Nov 18, 2021

gades referenced this in commit caafbc20f7 on May 9, 2022

gwillen referenced this in commit 06f0492f4a on Jun 1, 2022

bitcoin-core locked this on Aug 16, 2022

Peertableview alternating row colors #298

This gif offers many variations on table organization:

It is an easy change that helps organize textual information especially as the table gets larger.