scripted-diff: Make SeparatorStyle a scoped enum #3

1. 
   hebasto commented at 12:36 pm on June 18, 2020: member

   This PR is split from https://github.com/bitcoin/bitcoin/pull/17877 and makes BitcoinUnits::SeparatorStyle a scoped enum.
2. scripted-diff: Make SeparatorStyle a scoped enum

   -BEGIN VERIFY SCRIPT-
   # General rename helper: $1 -> $2
   rename_global() { sed -i "s/\<$1\>/$2/g" $(git grep -l "$1"); }
   
   # Helper to rename SeparatorStyle enumerators
   rename_value() {
     sed -i "s/    $1/    $2/g" src/qt/bitcoinunits.h;
     rename_global $1 "SeparatorStyle::$2";
   }
   
   rename_global 'enum SeparatorStyle' 'enum class SeparatorStyle'
   rename_value 'separatorNever' 'NEVER'
   rename_value 'separatorStandard' 'STANDARD'
   rename_value 'separatorAlways' 'ALWAYS'
   -END VERIFY SCRIPT-

   25f3554351
3. 
   MarcoFalke commented at 12:41 pm on June 18, 2020: contributor

   review ACK 25f3554351a99a0a695fbd2a6a0f293b3adc3d98 🚐

   Signature:

    0-----BEGIN PGP SIGNED MESSAGE-----
    1Hash: SHA512
    2
    3review ACK 25f3554351a99a0a695fbd2a6a0f293b3adc3d98 🚐
    4-----BEGIN PGP SIGNATURE-----
    5
    6iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
    7pUhW+wv9GQpElLmfINaNf+ze1SqvUA0BMd0WJihayZeYXdcyD8vWZummArqWbUZr
    8lpOmqvL9FCkK3IM0P1vtE/oXaM39NmieguCy56wVxNnMBiw5ypzv/E8RXyLZ3vTG
    9d1xeu8uUZv+DnW6BWnBFyAJrBewFb3AlbhBIOoUSObZN3pB4NV5zFPf4ASZwQH4x
   10bxX4f+fLe/fZes9/eln9OOA5mjL837dgEq95D990jonk/LbgXPup1weoo4fKETIK
   111V4iaUUMPWPBV3hBumzHtFqCRQ8SeJEt8v1nmUw7SKbtp0hsQcgGLRNAC4VaHyov
   12GIM6sXsgzRa8+n9iKGF1oknJnWqkP54hTNr1mr3KQlkNLcf6z/Ttk4tXfkRKkBh4
   13dTNXfr7bpU/9nKjyKdZ7D0VehK6AjZiMHZ7VGLR07lruOFUHJl/fujkJEuhTv+RL
   14a7WSAN2YDmgzGKGGYSFpBsevqHkY1oQKweyWG9SfKEEWqAJW5skzG7C6xZBrkcA7
   15B0DNFWQ1
   16=uYGY
   17-----END PGP SIGNATURE-----
   

   Timestamp of file with hash c2e1cf19f50c853bf07d563749f5d51b4e929abb7cf80d7eb4a46e25822b5ac1 -

4. MarcoFalke added the label refactoring on Jun 18, 2020
5. MarcoFalke merged this on Jun 18, 2020
6. MarcoFalke closed this on Jun 18, 2020

   ---

7. hebasto deleted the branch on Jun 18, 2020
8. laanwj referenced this in commit 31bdd86631 on Jul 15, 2020
9. laanwj referenced this in commit 924a4ff7eb on Oct 29, 2020
10. MarcoFalke referenced this in commit 027e51f715 on Nov 12, 2020
11. jonasschnelli referenced this in commit c33662a0ea on Dec 2, 2020
12. apoelstra referenced this in commit 6cb81893a3 on Dec 3, 2020
13. laanwj referenced this in commit e520e091db on Jan 6, 2021
14. gwillen referenced this in commit c3b6bbba4a on Mar 19, 2021
15. MarcoFalke referenced this in commit 590e49ccf2 on Apr 4, 2021
16. MarcoFalke referenced this in commit bce09da122 on Apr 28, 2021
17. fanquake referenced this in commit fa00bb2c5c on Apr 29, 2021
18. MarcoFalke referenced this in commit eb9a1fe037 on May 7, 2021
19. laanwj referenced this in commit ee9befe8b4 on May 12, 2021
20. MarcoFalke referenced this in commit c857148636 on May 15, 2021
21. deadalnix referenced this in commit b75671eabc on Aug 26, 2021
22. MarcoFalke referenced this in commit eb1f5706df on Sep 9, 2021
23. fanquake referenced this in commit fad381b2f8 on Jan 7, 2022
24. MarcoFalke referenced this in commit 444b6b342d on Feb 15, 2022
25. bitcoin-core locked this on Feb 15, 2022

Contributors
hebasto MarcoFalke

Labels
Refactoring