Disable the main window toolbar when the modal overlay is shown #30

pull hebasto wants to merge 2 commits into bitcoin-core:master from hebasto:200711-actions changing 3 files +12 −4

hebasto commented at 10:08 AM on July 11, 2020: member

Keeping the main window toolbar activated while the modal overlay is shown could create the appearance of the non-responsive GUI.

Fixes #22.

On master (ca055885c631de8ac0ffe24be6b02835dbcc039d):

With this PR:
qt, refactor: Cleanup ModalOverlay slots e74cd2083d
qt: Disable toolbar when overlay is shown d0cc1f6df7
harding commented at 4:56 PM on July 11, 2020: contributor

Tested ACK d0cc1f6df740e03ca0213a3754c3277b01ae2c05. Tested on Linux/X11 as much as I could given it's a pretty small change; seems like a nice improvement. I'm not experienced in Qt, but I don't see anything obviously problematic about the code.
leonardojobim commented at 4:20 PM on July 12, 2020: none

Tested ACK. Tested on Ubuntu 20.04 LTS. It can improve user experience.
jonatack commented at 4:38 AM on July 13, 2020: contributor

ACK d0cc1f6 tested on Debian 5.7.6-1 (2020-06-24) x86_64 GNU/Linux

Might need a macOS and Windows reviewer.
LarryRuane approved
LarryRuane commented at 6:13 AM on July 13, 2020: contributor

ACK d0cc1f6df740e03ca0213a3754c3277b01ae2c05 tested on Ubuntu 18.04.4 LTS I didn't review the code but verified the behavior with and without the PR, and that src/qt/test/test_bitcoin-qt passes.
MarcoFalke merged this on Jul 13, 2020
MarcoFalke closed this on Jul 13, 2020
hebasto deleted the branch on Jul 13, 2020
polylunar commented at 1:21 PM on July 13, 2020: none

Not sure whether it's still helpful but I tested it on MacOS and confirm it worked as well, nicely done @hebasto
jonatack commented at 4:01 PM on July 13, 2020: contributor

@polylunar thanks! It is very helpful to review before or after a merge. Great to see and looking forward to more tests and review from you :rocket:
sidhujag referenced this in commit 3fc98449de on Jul 14, 2020
apoelstra referenced this in commit 6f12d1a06c on Dec 3, 2020
gwillen referenced this in commit 822cc8251a on Mar 19, 2021
Fabcien referenced this in commit c113d22903 on Aug 31, 2021
bitcoin-core locked this on Feb 15, 2022

Contributors

Linked (view graph)

#7 Crash on exit #22 The GUI appears non-responsive when the 'still syncing' overlay is visible #796 ci_native_asan: UndefinedBehaviorSanitizer: null-pointer-use qt/test/wallettests.cpp:424:25 in